fix(common): viewport scroller not finding elements inside the shadow DOM #41644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
force-pushed
the
41470/viewport-scroller-shadow-dom
branch
from
a6d7eab
to
90fe285
Compare
atscott
approved these changes
Apr 15, 2021
… DOM The `ViewportScroller` figures out which element to scroll into view using `document.getElementById`. The problem is that it won't find elements inside the shadow DOM. These changes add some extra logic that goes through all the shadow roots to look for the element. Fixes angular#41470.
crisbeto
force-pushed
the
41470/viewport-scroller-shadow-dom
branch
from
90fe285
to
7f48e8f
Compare
crisbeto
added
action: merge
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 15, 2021
… DOM (#41644) The `ViewportScroller` figures out which element to scroll into view using `document.getElementById`. The problem is that it won't find elements inside the shadow DOM. These changes add some extra logic that goes through all the shadow roots to look for the element. Fixes #41470. PR Close #41644
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 15, 2021
… DOM (#41644) The `ViewportScroller` figures out which element to scroll into view using `document.getElementById`. The problem is that it won't find elements inside the shadow DOM. These changes add some extra logic that goes through all the shadow roots to look for the element. Fixes #41470. PR Close #41644
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ViewportScrollerfigures out which element to scroll into view usingdocument.getElementById. The problem is that it won't find elements inside the shadow DOM.These changes add some extra logic that goes through all the shadow roots to look for the element.
Fixes #41470.