Ngtsc/incremental redirects [patch] #41587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redirected source files When multiple occurrences of the same package exist within a single TypeScript compilation unit, TypeScript deduplicates the source files by introducing redirected source file proxies. Such proxies are recreated during an incremental compilation even if the original declaration file did not change, which caused the compiler not to reuse any work from the prior compilation. This commit changes the incremental driver to recognize a redirected source file and treat them as their unredirected source file.
JoostK
added
state: blocked
target: patch
JoostK
added
action: merge
|
caretaker note: this is a patch only PR so presubmit is not needed. |
zarend
approved these changes
Apr 13, 2021
|
Closed by commit 616145e |
zarend
pushed a commit
that referenced
this pull request
Apr 13, 2021
…redirected source files (#41587) When multiple occurrences of the same package exist within a single TypeScript compilation unit, TypeScript deduplicates the source files by introducing redirected source file proxies. Such proxies are recreated during an incremental compilation even if the original declaration file did not change, which caused the compiler not to reuse any work from the prior compilation. This commit changes the incremental driver to recognize a redirected source file and treat them as their unredirected source file. PR Close #41587
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41448 to patch. Marked as blocked for that one to land first.