fix(compiler-cli): Allow analysis to continue with invalid style url #41403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
state: WIP
area: compiler
atscott
added
target: patch
atscott
added
action: review
Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241
alxhub
requested changes
Apr 5, 2021
| styleUrl.url, containingFile, styleUrl.nodeForError, resourceType); | ||
| const resourceStr = this.resourceLoader.load(resourceUrl); | ||
| try { | ||
| const resourceUrl = this._resolveResourceOrThrow( |
There was a problem hiding this comment.
Rather than this try/catch, we should make _resolveResourceOrThrow not throw, and instead return some kind of error that we can choose to deal with (or ignore) as we see fit. Possibly this means its return value will be some kind of union between a success type and a failure type that also includes a diagnostic.
| diagnostics = []; | ||
| } | ||
| diagnostics.push(makeDiagnostic(e.code, e.node, e.message, e.relatedInformation)); | ||
| isPoisoned = true; |
There was a problem hiding this comment.
isPoisoned means "cannot be relied upon by consuming components" - a component shouldn't be poisoned because its own template or stylesheets are unavailable as they're not a part of its public API.
atscott
force-pushed
the
badcssresource
branch
2 times, most recently
from
64aa114
to
26fac59
Compare
alxhub
approved these changes
Apr 6, 2021
atscott
added
action: merge
atscott
added a commit
to atscott/angular
that referenced
this pull request
Apr 7, 2021
…ngular#41403) Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241 PR Close angular#41403
atscott
added a commit
to atscott/angular
that referenced
this pull request
Apr 7, 2021
…ngular#41403) Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241 PR Close angular#41403
atscott
added a commit
to atscott/angular
that referenced
this pull request
Apr 7, 2021
…ngular#41403) Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241 PR Close angular#41403
atscott
added a commit
that referenced
this pull request
Apr 7, 2021
…41403) (#41489) Currently, we throw a FatalDiagnosticError when we fail to load a resource (`templateUrl` or `styleUrl`) at various stages in the compiler. This prevents analysis of the component from completing. This will result in in users not being able to get any information in the component template when there is a missing `styleUrl`, for example. This commit simply tracks the diagnostic, marks the component as poisoned, and continues merrily along. Environments configured to use poisoned data (like the language service) will then be able to use other information from the analysis. Fixes angular/vscode-ng-language-service#1241 PR Close #41403 PR Close #41489
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we throw a FatalDiagnosticError when we fail to load a resource
(
templateUrlorstyleUrl) at various stages in the compiler. This preventsanalysis of the component from completing. This will result in in users not being
able to get any information in the component template when there is a missing
styleUrl, for example.This commit simply tracks the diagnostic, marks the component as poisoned, and
continues merrily along. Environments configured to use poisoned data
(like the language service) will then be able to use other information from the analysis.
Fixes angular/vscode-ng-language-service#1241