fix(common): temporarily re-export and deprecate XhrFactory
#41393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 454f9a3 at https://pr41393-454f9a3.ngbuilds.io/. |
petebacondarwin
force-pushed
the
xhr-factory-reexport
branch
from
454f9a3
to
60f4504
Compare
|
You can preview 60f4504 at https://pr41393-60f4504.ngbuilds.io/. |
petebacondarwin
force-pushed
the
xhr-factory-reexport
branch
2 times, most recently
from
15d17bd
to
2509b87
Compare
|
You can preview 2509b87 at https://pr41393-2509b87.ngbuilds.io/. |
petebacondarwin
force-pushed
the
xhr-factory-reexport
branch
from
2509b87
to
afa3d38
Compare
|
You can preview afa3d38 at https://pr41393-afa3d38.ngbuilds.io/. |
The moved `XhrFactory` still needs to be available from `@angular/common/http` for some libraries that were built prior to 12.0.0, otherwise they cannot be used in applications built post-12.0.0. This commit adds back the re-export of `XhrFactory` and deprecates it.
petebacondarwin
force-pushed
the
xhr-factory-reexport
branch
from
afa3d38
to
f625e20
Compare
petebacondarwin
changed the title
XhrFactory
petebacondarwin
added
action: review
|
You can preview f625e20 at https://pr41393-f625e20.ngbuilds.io/. |
atscott
approved these changes
Mar 31, 2021
petebacondarwin
commented
Mar 31, 2021
packages/misc/angular-in-memory-web-api/src/in-memory-web-api-module.ts
Outdated
Show resolved
Hide resolved
|
You can preview f69734e at https://pr41393-f69734e.ngbuilds.io/. |
alan-agius4
approved these changes
Mar 31, 2021
gkalpak
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
👍
Shouldn't we also add a note in aio/content/guide/deprecations.md?
gkalpak
added
the
action: cleanup
We now include `misc/angular-in-memory-web-api` in the packages that are build in the `dist/packages-dist` directory. But this package should not be published as an artifact. This commit prevents attempting to publishing the `misc` directory by first checking whether the directory contains a `package.json` file.
petebacondarwin
force-pushed
the
xhr-factory-reexport
branch
from
f69734e
to
3e30358
Compare
|
You can preview 3e30358 at https://pr41393-3e30358.ngbuilds.io/. |
AndrewKushnir
approved these changes
Apr 1, 2021
AndrewKushnir
approved these changes
Apr 1, 2021
jelbourn
approved these changes
Apr 1, 2021
jelbourn
approved these changes
Apr 1, 2021
AndrewKushnir
added
area: common
|
@petebacondarwin FYI presubmits are successful for the changes in this PR. |
AndrewKushnir
removed
the
action: presubmit
petebacondarwin
removed request for
IgorMinar,
atscott,
crisbeto,
gkalpak and
jessicajaniuk
petebacondarwin
added
the
action: merge
alxhub
added
target: major
alxhub
pushed a commit
that referenced
this pull request
Apr 1, 2021
We now include `misc/angular-in-memory-web-api` in the packages that are build in the `dist/packages-dist` directory. But this package should not be published as an artifact. This commit prevents attempting to publishing the `misc` directory by first checking whether the directory contains a `package.json` file. PR Close #41393
TeriGlover
pushed a commit
to TeriGlover/angular
that referenced
this pull request
Apr 5, 2021
…r#41393) The moved `XhrFactory` still needs to be available from `@angular/common/http` for some libraries that were built prior to 12.0.0, otherwise they cannot be used in applications built post-12.0.0. This commit adds back the re-export of `XhrFactory` and deprecates it. PR Close angular#41393
TeriGlover
pushed a commit
to TeriGlover/angular
that referenced
this pull request
Apr 5, 2021
…41393) We now include `misc/angular-in-memory-web-api` in the packages that are build in the `dist/packages-dist` directory. But this package should not be published as an artifact. This commit prevents attempting to publishing the `misc` directory by first checking whether the directory contains a `package.json` file. PR Close angular#41393
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs show deprecation notice: https://pr41393-f625e20.ngbuilds.io/api/common/http/XhrFactory
Tested against ngcc-validation: angular/ngcc-validation#2820
Deprecation message also shows in IDE: