fix(router): remove child outlet context from parent on deactivation #41381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
action: review
pullapprove
bot
requested review from
AndrewKushnir,
IgorMinar,
jelbourn and
jessicajaniuk
atscott
force-pushed
the
deactivateChildOutlet
branch
from
9f26373
to
a078698
Compare
atscott
removed request for
IgorMinar,
jelbourn,
AndrewKushnir and
jessicajaniuk
pullapprove
bot
requested review from
AndrewKushnir,
IgorMinar,
jelbourn and
jessicajaniuk
atscott
removed
the
action: review
atscott
removed request for
AndrewKushnir,
IgorMinar,
jelbourn and
jessicajaniuk
atscott
force-pushed
the
deactivateChildOutlet
branch
from
a078698
to
7f56bef
Compare
…ating route When we deactivate a child route, we deactivate its outlet as well as its children. We also need to clear the stored information about the route and the associated component. If we do not, the context will keep these references and can result in reactivating an outlet that was deactivated by the previous navigation. Fixes angular#41379
atscott
force-pushed
the
deactivateChildOutlet
branch
from
7f56bef
to
4f94113
Compare
atscott
removed
action: presubmit
zarend
pushed a commit
that referenced
this pull request
Apr 7, 2021
…ating route (#41381) When we deactivate a child route, we deactivate its outlet as well as its children. We also need to clear the stored information about the route and the associated component. If we do not, the context will keep these references and can result in reactivating an outlet that was deactivated by the previous navigation. Fixes #41379 PR Close #41381
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we deactivate a child route, we deactivate its outlet as well as
its children. We also need to remove this context from the parent
Map.If we do not, the parent will hold on to a reference to this deactivated
context and can result in reactivating an outlet that was deactivated by
the previous navigation.
Fixes #41379