perf(forms): avoid direct references to the Validators class
#41189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
area: performance
state: WIP
area: forms
target: patch
|
Note: this PR is related to (and partially addresses) #41011. |
AndrewKushnir
added
action: review
alfaproject
reviewed
Mar 12, 2021
AndrewKushnir
added
action: merge
Currently the `Validators` class contains a number of static methods that represent different validators as well as some helper methods. Since class methods are not tree-shakable, any reference to the `Validator` class retains all of its methods (even if you've used just one). This commit refactors the code to extract the logic into standalone functions and use these functions in the code instead of referencing them via `Validators` class. That should make the code more tree-shakable. The `Validators` class still retains its structure and calls these standalone methods internally to keep this change backwards-compatible.
jessicajaniuk
force-pushed
the
form-tree-shake-validators-class
branch
from
04d293e
to
966d897
Compare
jessicajaniuk
added
target: major
|
This has been merged into master only due to conflicts with 11.2.x. @AndrewKushnir can you create a patch-only PR for 11.2.x? |
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
Mar 15, 2021
…ar#41189) Currently the `Validators` class contains a number of static methods that represent different validators as well as some helper methods. Since class methods are not tree-shakable, any reference to the `Validator` class retains all of its methods (even if you've used just one). This commit refactors the code to extract the logic into standalone functions and use these functions in the code instead of referencing them via `Validators` class. That should make the code more tree-shakable. The `Validators` class still retains its structure and calls these standalone methods internally to keep this change backwards-compatible. PR Close angular#41189
This was referenced Mar 18, 2021
Merged
Closed
This was referenced Mar 18, 2021
Closed
|
I came across this whilst looking through the CHANGELOG and updating Angular Is this just an internal change or do users of I have quite a lot of code that looks something like this: public emailControl = new FormControl("", [Validators.email, Validators.required]);Does it need to be written in a different way to be tree-shakeable? |
|
@ockendenjo It's an internal only change for now, so your code is not affected (nor can it benefit from this change at the moment). Please see #41257 for details. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
Validatorsclass contains a number of static methods that represent different validators as well as some helper methods. Since class methods are not tree-shakable, any reference to theValidatorclass retains all of its methods (even if you've used just one).This commit refactors the code to extract the logic into standalone functions and use these functions in the code instead of referencing them via
Validatorsclass. That should make the code more tree-shakable. TheValidatorsclass still retains its structure and calls these standalone methods internally to keep this change backwards-compatible.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?