Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(localize): trim extracted equiv-text values #41180

Closed
wants to merge 1 commit into from
Closed

fix(localize): trim extracted equiv-text values #41180

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Member

The ViewEngine message extraction would trim the values
of the equiv-text attributes. This commit aligns the Ivy
extraction of these attributes.

Fixes #41176

@petebacondarwin
fix(localize): trim extracted equiv-text values
ff24c05 
The ViewEngine message extraction would trim the values
of the `equiv-text` attributes. This commit aligns the Ivy
extraction of these attributes.

Fixes angular#41176
@petebacondarwin petebacondarwin added area: i18n target: patch This PR is targeted for the next patch release engine: ivy labels Mar 11, 2021
@google-cla google-cla bot added the cla: yes label Mar 11, 2021
@ngbot ngbot bot modified the milestone: Backlog Mar 11, 2021
@petebacondarwin petebacondarwin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 11, 2021
@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Mar 11, 2021
AndrewKushnir
AndrewKushnir approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 11, 2021
AndrewKushnir pushed a commit that referenced this pull request Mar 11, 2021
@petebacondarwin @AndrewKushnir
fix(localize): trim extracted equiv-text values (#41180)
ed6c09a 
The ViewEngine message extraction would trim the values
of the `equiv-text` attributes. This commit aligns the Ivy
extraction of these attributes.

Fixes #41176

PR Close #41180
This was referenced Mar 17, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 18, 2021
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@petebacondarwin petebacondarwin deleted the i18n-equiv-text-trimming-issue-41176 branch March 22, 2021 14:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: i18n cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

i18n: equiv-text value is not trimmed
2 participants
@petebacondarwin @AndrewKushnir