Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): drop support for zone.js 0.10.x #40823

Closed
wants to merge 3 commits into from
Closed

feat(core): drop support for zone.js 0.10.x #40823

wants to merge 3 commits into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Feb 12, 2021

With this change we drop support for zone.js 0.10.x.
This is needed because in version 12 the CLI will only work with ~0.11.4. See angular/angular-cli#20034.

BREAKING CHANGE:

Minimum supported zone.js version is 0.11.4

@alan-agius4 alan-agius4 marked this pull request as draft February 12, 2021 10:17
@google-cla google-cla bot added the cla: yes label Feb 12, 2021
@alan-agius4 alan-agius4 added action: time-zone breaking changes target: major This PR is targeted for the next major release labels Feb 12, 2021
@alan-agius4 alan-agius4 marked this pull request as ready for review February 12, 2021 11:06
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 12, 2021
@josephperrott josephperrott added area: common/http area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime comp: docs-infra area: upgrade Issues related to AngularJS → Angular upgrade APIs labels Feb 12, 2021
@ngbot ngbot bot modified the milestone: Backlog Feb 12, 2021
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay 🎉

I still see some occurrences of zone.js/dist/... (mostly in error messages and docs. They should also be updated, right?

Also, I think we should add the zone.js/plugins/ directory in .github/angular-robot.yml:

- "packages/zone.js/*"
- "packages/zone.js/dist/**"
- "packages/zone.js/doc/**"
- "packages/zone.js/example/**"
- "packages/zone.js/scripts/**"

I accept that some (or maybe all) of these changes are not directly related to this PR (and should have happened independently). I am bringing them up as you seem to have made similar changes in other places as part of this PR, but happy to captrure them in an issue to make them in a new PR (also happy to take them on).

BTW, there are some minor typos in the commit messages:

  • One of the commits says "Minimum supported zone.js version is 0.11.1", but based on the changes in packages/core/package.json, it seems that 0.11.3 is the minimum required version. Do I miss something?
  • -This is needed because in version 12. The CLI will only work with 0.11.x. angular/angular-cli#20034
    +This is needed because in version 12 the CLI will only work with 0.11.x. See angular/angular-cli#20034.
  • -In CLI version 12, the old style of imports are no longer supported.
    +In CLI version 12, the old style of imports is no longer supported.
  • zone.js incosistently appearing both wrapped in backticks and unwrapped 😁
  • Some trailing periods are missing 😁

aio/tools/examples/shared/yarn.lock Outdated Show resolved Hide resolved
aio/tools/examples/shared/yarn.lock Outdated Show resolved Hide resolved
aio/tools/examples/shared/yarn.lock Outdated Show resolved Hide resolved
@alan-agius4
Copy link
Contributor Author

Thanks for the review @gkalpak. I can definitely that the other suggest changes.

Let me get back to this PR on Monday.

@JiaLiPassion
Copy link
Contributor

@alan-agius4 , since zone.js 0.11.1~0.11.3 has an issue with es2015 bundle, and it has been fixed here #40456, and is available in 0.11.4. This issue will have some impact when user using the new bundle import 'zone.js' , So I think maybe we should use the new 0.11.4 version as the minimum support version?

@alan-agius4
Copy link
Contributor Author

@JiaLiPassion, that would be possible, when is 0.11.4 scheduled to be released?

@JiaLiPassion
Copy link
Contributor

@alan-agius4 , the release PR has been merged, I believe it will be released very soon.

@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Feb 15, 2021

@JiaLiPassion & @gkalpak, I update the PR once zone.js 0.11.4 is released I'll update the PR with the new version.

@JiaLiPassion, can you please prioritize a zone.js release? Since this will also need to be synced in angular/angular-cli#20034

@JiaLiPassion
Copy link
Contributor

@alan-agius4 , sure, I will contact @mhevery to make the new release.

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, @alan-agius4! Very thorough 💯

One last thing:
Should we update the reference to Angular CLI in packages/zone.js/README.md (line 32)?

-If you are using `Angular CLI`, the `polyfills.ts` file will contain:
+If you are using an older `Angular CLI`, the `polyfills.ts` file will contain:

(...or something along those lines.)

.github/angular-robot.yml Outdated Show resolved Hide resolved
packages/zone.js/NON-STANDARD-APIS.md Outdated Show resolved Hide resolved
packages/zone.js/MODULE.md Show resolved Hide resolved
@alan-agius4 alan-agius4 requested review from josephperrott and removed request for IgorMinar February 17, 2021 07:50
@alan-agius4
Copy link
Contributor Author

Updated PR to use zone.js 0.11.4.

.github/angular-robot.yml Outdated Show resolved Hide resolved
In CLI version 12, the old style of imports is no longer supported.
In CLI version 12, the old style of imports is no longer supported.
With this change we drop support for zone.js 0.10.x.
This is needed because in version 12 the CLI will only work with `~0.11.4`. See angular/angular-cli#20034.

BREAKING CHANGE:

Minimum supported `zone.js` version is `0.11.4`
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 17, 2021
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Feb 24, 2021
@atscott atscott closed this in d51d39c Feb 24, 2021
atscott pushed a commit that referenced this pull request Feb 24, 2021
In CLI version 12, the old style of imports is no longer supported.

PR Close #40823
atscott pushed a commit that referenced this pull request Feb 24, 2021
With this change we drop support for zone.js 0.10.x.
This is needed because in version 12 the CLI will only work with `~0.11.4`. See angular/angular-cli#20034.

BREAKING CHANGE:

Minimum supported `zone.js` version is `0.11.4`

PR Close #40823
@alan-agius4 alan-agius4 deleted the zone-js-11 branch February 24, 2021 16:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: common/http area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime area: upgrade Issues related to AngularJS → Angular upgrade APIs breaking changes cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants