New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): drop support for zone.js 0.10.x #40823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay 🎉
I still see some occurrences of zone.js/dist/...
(mostly in error messages and docs. They should also be updated, right?
- aio/content/guide/testing-components-scenarios.md
- dev-infra/BUILD.bazel
- packages/core/src/testability/testability.ts
- packages/core/testing/src/async.ts
- packages/localize/schematics/ng-add/index_spec.ts
- packages/zone.js/MODULE.md
- packages/zone.js/NON_STANDARD_APIS.md
- packages/zone.js/README.md
- packages/zone.js/lib/zone-spec/async-test.ts
- packages/zone.js/lib/zone-spec/fake-async-test.ts
Also, I think we should add the zone.js/plugins/
directory in .github/angular-robot.yml
:
angular/.github/angular-robot.yml
Lines 76 to 80 in 838e3bd
- "packages/zone.js/*" | |
- "packages/zone.js/dist/**" | |
- "packages/zone.js/doc/**" | |
- "packages/zone.js/example/**" | |
- "packages/zone.js/scripts/**" |
I accept that some (or maybe all) of these changes are not directly related to this PR (and should have happened independently). I am bringing them up as you seem to have made similar changes in other places as part of this PR, but happy to captrure them in an issue to make them in a new PR (also happy to take them on).
BTW, there are some minor typos in the commit messages:
- One of the commits says "Minimum supported
zone.js
version is0.11.1
", but based on the changes inpackages/core/package.json
, it seems that0.11.3
is the minimum required version. Do I miss something? -
-This is needed because in version 12. The CLI will only work with 0.11.x. angular/angular-cli#20034 +This is needed because in version 12 the CLI will only work with 0.11.x. See angular/angular-cli#20034.
-
-In CLI version 12, the old style of imports are no longer supported. +In CLI version 12, the old style of imports is no longer supported.
zone.js
incosistently appearing both wrapped in backticks and unwrapped 😁- Some trailing periods are missing 😁
Thanks for the review @gkalpak. I can definitely that the other suggest changes. Let me get back to this PR on Monday. |
@alan-agius4 , since |
@JiaLiPassion, that would be possible, when is 0.11.4 scheduled to be released? |
@alan-agius4 , the release PR has been merged, I believe it will be released very soon. |
@JiaLiPassion & @gkalpak, I update the PR once @JiaLiPassion, can you please prioritize a zone.js release? Since this will also need to be synced in angular/angular-cli#20034 |
@alan-agius4 , sure, I will contact @mhevery to make the new release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, @alan-agius4! Very thorough 💯
One last thing:
Should we update the reference to Angular CLI in packages/zone.js/README.md (line 32)?
-If you are using `Angular CLI`, the `polyfills.ts` file will contain:
+If you are using an older `Angular CLI`, the `polyfills.ts` file will contain:
(...or something along those lines.)
Updated PR to use zone.js 0.11.4. |
In CLI version 12, the old style of imports is no longer supported.
In CLI version 12, the old style of imports is no longer supported.
With this change we drop support for zone.js 0.10.x. This is needed because in version 12 the CLI will only work with `~0.11.4`. See angular/angular-cli#20034. BREAKING CHANGE: Minimum supported `zone.js` version is `0.11.4`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In CLI version 12, the old style of imports is no longer supported. PR Close #40823
With this change we drop support for zone.js 0.10.x. This is needed because in version 12 the CLI will only work with `~0.11.4`. See angular/angular-cli#20034. BREAKING CHANGE: Minimum supported `zone.js` version is `0.11.4` PR Close #40823
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
With this change we drop support for zone.js 0.10.x.
This is needed because in version 12 the CLI will only work with
~0.11.4
. See angular/angular-cli#20034.BREAKING CHANGE:
Minimum supported
zone.js
version is0.11.4