-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n Ivy extractor only reports the first location context #39330
Labels
area: i18n
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
state: has PR
Milestone
Comments
petebacondarwin
added
area: i18n
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
labels
Oct 19, 2020
Thanks for this @laurentgoudet |
This was referenced Oct 19, 2020
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this issue
Oct 24, 2020
Previously only the first message, for each id, was serialized which meant that additional message location information was lost. Now all the message locations are included in the serialized messages. Fixes angular#39330
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this issue
Oct 24, 2020
Previously only the first message, for each id, was serialized which meant that additional message location information was lost. Now all the message locations are included in the serialized messages. Fixes angular#39330
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: i18n
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
state: has PR
Small repro in https://github.com/laurentgoudet/ivy-xi18n-bug.
Steps:
ng add @angular/localize
i18n
tags to a couple of tags, one of them being duplicated (https://github.com/laurentgoudet/ivy-xi18n-bug/blob/master/src/app/app.component.html#L343), to simulate the same piece of text being repeated across an applicationng xi18n
: the dictionary (https://github.com/laurentgoudet/ivy-xi18n-bug/blob/master/messages-ve.xlf) shows all the location referencesng x18n --ivy
: the dictionary (https://github.com/laurentgoudet/ivy-xi18n-bug/blob/master/messages.xlf) only shows the first location referenceThis means translators have less context to understand how a piece of text is used across an app.
The text was updated successfully, but these errors were encountered: