fix(core): incorrectly validating properties on ng-content and ng-container #37773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
area: core
alxhub
approved these changes
Jul 7, 2020
crisbeto
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
FYI, I've started a new presubmit (the previous one had some flakes). @crisbeto could you please also rebase this PR (to re-run CI with the most recent version of changes in master branch)? |
|
Rebased. |
crisbeto
force-pushed
the
FW-2268/invalid-property-detection
branch
from
d453a34
to
2c9a517
Compare
|
@crisbeto presubmit looks good, but the |
AndrewKushnir
added
action: cleanup
…tainer Fixes the following issues related to how we validate properties during JIT: - The invalid property warning was printing `null` as the node name for `ng-content`. The problem is that when generating a template from `ng-content` we weren't capturing the node name. - We weren't running property validation on `ng-container` at all. This used to be supported on ViewEngine and seems like an oversight. In the process of making these changes, I found and cleaned up a few places where we were passing in `LView` unnecessarily.
crisbeto
force-pushed
the
FW-2268/invalid-property-detection
branch
from
2c9a517
to
74c6722
Compare
crisbeto
removed
the
action: cleanup
|
Fixed the lint issue. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 15, 2020
…tainer (#37773) Fixes the following issues related to how we validate properties during JIT: - The invalid property warning was printing `null` as the node name for `ng-content`. The problem is that when generating a template from `ng-content` we weren't capturing the node name. - We weren't running property validation on `ng-container` at all. This used to be supported on ViewEngine and seems like an oversight. In the process of making these changes, I found and cleaned up a few places where we were passing in `LView` unnecessarily. PR Close #37773
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…tainer (angular#37773) Fixes the following issues related to how we validate properties during JIT: - The invalid property warning was printing `null` as the node name for `ng-content`. The problem is that when generating a template from `ng-content` we weren't capturing the node name. - We weren't running property validation on `ng-container` at all. This used to be supported on ViewEngine and seems like an oversight. In the process of making these changes, I found and cleaned up a few places where we were passing in `LView` unnecessarily. PR Close angular#37773
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues related to how we validate properties during JIT:
nullas the node name forng-content. The problem is that when generating a template fromng-contentwe weren't capturing the node name.ng-containerat all. This used to be supported on ViewEngine and seems like an oversight.In the process of making these changes, I found and cleaned up a few places where we were passing in
LViewunnecessarily.