New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngcc generate inline sourcemaps in .d.ts
files and break completely DX
#37324
Comments
Currently ngcc tries to guess whether to add source-mapping inline or as an external file. |
As a workaround (meanwhile it's fixed), I'm removing source-maps by hand... but it's a pain 😓 |
Inline source-maps in typings files can impact IDE performance so ngcc should only add such maps if the original typings file contains inline source-maps. Fixes angular#37324
…ps (angular#37363) Inline source-maps in typings files can impact IDE performance so ngcc should only add such maps if the original typings file contains inline source-maps. Fixes angular#37324 PR Close angular#37363
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…ps (angular#37363) Inline source-maps in typings files can impact IDE performance so ngcc should only add such maps if the original typings file contains inline source-maps. Fixes angular#37324 PR Close angular#37363
🐞 bug report
Affected Package
The issue is caused by package @angular/ALL
Is this a regression?
I think yes, the previous version in which this bug was not present was: I don't know, maybe
8.x.x
.Description
When
ngcc
run it appends a massive source-map at the end of definition files (.d.ts
) in every angular package, and it gets stuck my code editor (vscode
). I have to restartvscode
to kill thetsserver
, and avoid to enter to anyangular
's file definition.🔬 Minimal Reproduction
ng new ...
,npm run start
(to runngcc
) and follow, for example,Component
definition to its.d.ts
file at@angular/core
. VSCode andng-language-service
take a lot of time to process the file and consume a lot of CPU.🔥 Exception or Error
🌍 Your Environment
Angular Version:
Anything else relevant?
The text was updated successfully, but these errors were encountered: