fix(language-service): Recover from error in analyzing Ng Modules #37108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayazhafiz
commented
May 14, 2020
kyliau
suggested changes
May 14, 2020
ayazhafiz
added
area: language-service
|
ptal @kyliau. The error messages we get from resolution failure would make great diagnostics, so I think we should look into propagating it from the compiler. |
kyliau
reviewed
Jun 1, 2020
| @@ -71,6 +71,8 @@ export class TypeScriptServiceHost implements LanguageServiceHost { | |||
| ngModuleByPipeOrDirective: new Map(), | |||
| ngModules: [], | |||
| }; | |||
| private lastAnalysisSucceeded = true; | |||
There was a problem hiding this comment.
Is there any reason why this flag is needed? I think the code would work without it.
There was a problem hiding this comment.
yeah sorry, an artifact of when i was doing the spy thing and didn't update source files
kyliau
approved these changes
Jun 1, 2020
kyliau
added
action: cleanup
In place of failing to return analyzed Ng Modules when the analyzer fails, return the previously-analyzed Ng Modules (which may be empty) and log an error. Closes angular/vscode-ng-language-service#777
kyliau
removed
the
action: cleanup
atscott
pushed a commit
that referenced
this pull request
Jun 3, 2020
…7108) In place of failing to return analyzed Ng Modules when the analyzer fails, return the previously-analyzed Ng Modules (which may be empty) and log an error. Closes angular/vscode-ng-language-service#777 PR Close #37108
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
…gular#37108) In place of failing to return analyzed Ng Modules when the analyzer fails, return the previously-analyzed Ng Modules (which may be empty) and log an error. Closes angular/vscode-ng-language-service#777 PR Close angular#37108
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…gular#37108) In place of failing to return analyzed Ng Modules when the analyzer fails, return the previously-analyzed Ng Modules (which may be empty) and log an error. Closes angular/vscode-ng-language-service#777 PR Close angular#37108
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes angular/vscode-ng-language-service#777
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?