Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase AIO payload size limit #35538

Closed

Conversation

AndrewKushnir
Copy link
Contributor

This commit updates AIO payload size limit that is triggering a problem after merging f95b8ce. That commit added some payload size, but all checks were "green" for the PR (#34481) after rebase that happened a couple hours before the merge, so this is an accumulated payload size increase from multiple changes. The goal of this commit is to bring the master and patch branches back to "green" state.

PR Type

What kind of change does this PR introduce?

  • CI related changes

Does this PR introduce a breaking change?

  • Yes
  • No

This commit updates AIO payload size limit that is triggering a problem after merging angular@f95b8ce. That commit added some payload size, but all checks were "green" for the PR (angular#34481) after rebase that happened a couple hours before the merge, so this is an accumulated payload size increase from multiple changes. The goal of this commit is to bring the master and patch branches back to "green" state.
@AndrewKushnir AndrewKushnir added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 19, 2020
@ngbot ngbot bot added this to the needsTriage milestone Feb 19, 2020
@AndrewKushnir AndrewKushnir marked this pull request as ready for review February 19, 2020 01:59
@pullapprove pullapprove bot requested review from gkalpak and kara February 19, 2020 01:59
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm for payload size check

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 19, 2020
@alxhub alxhub closed this in d0d36a5 Feb 19, 2020
alxhub pushed a commit that referenced this pull request Feb 19, 2020
This commit updates AIO payload size limit that is triggering a problem after merging f95b8ce. That commit added some payload size, but all checks were "green" for the PR (#34481) after rebase that happened a couple hours before the merge, so this is an accumulated payload size increase from multiple changes. The goal of this commit is to bring the master and patch branches back to "green" state.

PR Close #35538
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants