Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-infra): set th/td to proper width #35437

Closed
wants to merge 4 commits into from

Conversation

sonukapoor
Copy link
Contributor

@sonukapoor sonukapoor commented Feb 14, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

image

What is the new behavior?

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from IgorMinar February 14, 2020 02:26
@gkalpak gkalpak added aio: preview comp: docs-infra action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release type: bug/fix labels Feb 14, 2020
@mary-poppins
Copy link

You can preview 610a750 at https://pr35437-610a750.ngbuilds.io/.

@ngbot ngbot bot modified the milestone: needsTriage Feb 14, 2020
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

aio/src/styles/2-modules/_table.scss Outdated Show resolved Hide resolved
aio/src/styles/2-modules/_table.scss Outdated Show resolved Hide resolved
aio/src/styles/2-modules/_table.scss Outdated Show resolved Hide resolved
@mary-poppins
Copy link

You can preview 916fb4f at https://pr35437-916fb4f.ngbuilds.io/.

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for making the changes, @sonukapoor! Can you also change the commit message type/scope to fix(docs-infra): ...?

aio/src/styles/2-modules/_table.scss Outdated Show resolved Hide resolved
Previously, the tables on the event page were misaligned. This commit
fixes this by setting the width of all `td`'s and `th`'s.
@mary-poppins
Copy link

You can preview 874b0f4 at https://pr35437-874b0f4.ngbuilds.io/.

@gkalpak gkalpak changed the title docs: set default width of first th and last td in events table fix(docs-infra): set th/td to proper width Feb 17, 2020
aio/src/styles/2-modules/_table.scss Outdated Show resolved Hide resolved
aio/src/styles/2-modules/_table.scss Outdated Show resolved Hide resolved
Co-Authored-By: George Kalpakas <kalpakas.g@gmail.com>
@mary-poppins
Copy link

You can preview e6991f3 at https://pr35437-e6991f3.ngbuilds.io/.

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@gkalpak gkalpak removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 17, 2020
@gkalpak gkalpak removed the request for review from IgorMinar February 17, 2020 17:10
@gkalpak gkalpak added the action: merge The PR is ready for merge by the caretaker label Feb 17, 2020
alxhub pushed a commit that referenced this pull request Feb 18, 2020
Previously, the tables on the event page were misaligned. This commit
fixes this by setting the width of all `td`'s and `th`'s.

PR Close #35437
@alxhub alxhub closed this in 183a862 Feb 18, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants