Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove support for Map/Set in [class]/[style] bind… #35392

Closed
wants to merge 1 commit into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Feb 12, 2020

…ings

Close FW-1863

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mhevery mhevery added area: core Issues related to the framework runtime comp: ivy target: patch This PR is targeted for the next patch release labels Feb 12, 2020
@ngbot ngbot bot added this to the needsTriage milestone Feb 12, 2020
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.. let's discuss this in fw meeting and revisit reenabling the support once we are sure this won't be a perf footgun

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Feb 12, 2020
@IgorMinar IgorMinar removed the request for review from pkozlowski-opensource February 12, 2020 23:53
@IgorMinar IgorMinar added the action: presubmit The PR is in need of a google3 presubmit label Feb 12, 2020
@IgorMinar
Copy link
Contributor

@mhevery can you please presubmit this? Thanks

@kara
Copy link
Contributor

kara commented Feb 14, 2020

presubmit

@mhevery mhevery requested a review from kara February 14, 2020 03:48
@mhevery mhevery removed the action: presubmit The PR is in need of a google3 presubmit label Feb 14, 2020
@mhevery mhevery removed the request for review from kara February 14, 2020 03:51
@alxhub alxhub closed this in 2ca7984 Feb 14, 2020
alxhub pushed a commit that referenced this pull request Feb 14, 2020
@mhevery mhevery deleted the fw-1863 branch February 14, 2020 21:35
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 17, 2020
@arlowhite
Copy link

I was curious about the reasoning/history behind this (for curiosities sake, not impacted), but there's very little information here and the JIRA link doesn't work for me (endless redirect loop on Choose or add another account screen).

If JIRA is non-public, linking JIRA isn't verify open source friendly.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants