fix(ivy): error if directive with synthetic property binding is on same node as directive that injects ViewContainerRef #35343
Conversation
…me node as directive that injects ViewContainerRef In the `loadRenderer` we make an assumption that the value will always be an `LView`, but if there's a directive on the same node which injects `ViewContainerRef` the `LView` will be wrapped in an `LContainer`. These changes add a call to unwrap the value before we try to read the value off of it. Fixes angular#35342.
crisbeto
added
comp: ivy
action: review
| expect(() => { | ||
| const fixture = TestBed.createComponent(App); | ||
| fixture.detectChanges(); | ||
| }).not.toThrow(); |
There was a problem hiding this comment.
I don't think that you need explicit not.toThrow(); a test would fail in case of an exception thrown.
There was a problem hiding this comment.
I actually prefer this as it makes it very clear what you are testing. Without this it is harder to understand what exactly you are testing. I think of it as a marker.
There was a problem hiding this comment.
Hmmm, I hear what you say about marker and this is a good point. The problem I've got with such assertion, though, is that this test is going to pass even if nothing happens / gets rendered. I could pretty much delete the entire template and the test would still pass.
This is why, personally, I prefer to have a more concrete assert... Definitively don't want to split a hair over this one, just sharing personal preference / how I think about it...
mhevery
added
action: merge
…me node as directive that injects ViewContainerRef (#35343) In the `loadRenderer` we make an assumption that the value will always be an `LView`, but if there's a directive on the same node which injects `ViewContainerRef` the `LView` will be wrapped in an `LContainer`. These changes add a call to unwrap the value before we try to read the value off of it. Fixes #35342. PR Close #35343
…me node as directive that injects ViewContainerRef (angular#35343) In the `loadRenderer` we make an assumption that the value will always be an `LView`, but if there's a directive on the same node which injects `ViewContainerRef` the `LView` will be wrapped in an `LContainer`. These changes add a call to unwrap the value before we try to read the value off of it. Fixes angular#35342. PR Close angular#35343
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In the
loadRendererwe make an assumption that the value will always be anLView, but if there's a directive on the same node which injectsViewContainerReftheLViewwill be wrapped in anLContainer. These changes add a call to unwrap the value before we try to read the value off of it.Fixes #35342.