Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't attach a matTooltip to mat-expansion-panel-header since 9.0.0 #35342

Closed
tadzik opened this issue Feb 10, 2020 · 2 comments
Closed

Can't attach a matTooltip to mat-expansion-panel-header since 9.0.0 #35342

tadzik opened this issue Feb 10, 2020 · 2 comments
Assignees
@crisbeto
Labels
freq2: medium regression Indicates than the issue relates to something that worked in a previous version state: has PR
Milestone
needsTriage

Comments

@tadzik
Copy link

tadzik commented Feb 10, 2020

Reproduction

Steps to reproduce:

  1. Clone and run https://github.com/tadzik/angular-material-bug
  2. Observe the browser console

Alternatively: try to attach a matTooltip to a mat-expansion-panel-header, as you could in angular/material 8.

Expected Behavior

Everything works as expected without exceptions thrown.

Actual Behavior

Component (?) crashes:

ERROR TypeError: "renderer is undefined"
    Angular 8
        isProceduralRenderer
        listenerInternal
        componentHostSyntheticListener
        MatExpansionPanelHeader_HostBindings
        invokeHostBindingsInCreationMode
        invokeDirectivesHostBindings
        createDirectivesInstances
        elementStart
    AppComponent_Template app.component.html:2
    Angular 20
core.js:5828:19

Removing the matTooltip on mat-expansion-panel-header fixes the issue – but removes the tooltip too :)

Environment

  • Angular: 9
  • CDK/Material: 9
  • Browser(s): Firefox
  • Operating System (e.g. Windows, macOS, Ubuntu): Ubuntu
@crisbeto crisbeto self-assigned this Feb 11, 2020
@crisbeto
Copy link
Member

Looks like this is a bug in core. I've got a fix, but I'll transfer the issue to the proper repo so that it's tracked correctly.

@crisbeto crisbeto transferred this issue from angular/components Feb 11, 2020
@crisbeto crisbeto added regression Indicates than the issue relates to something that worked in a previous version comp: ivy freq2: medium labels Feb 11, 2020
@ngbot ngbot bot added this to the needsTriage milestone Feb 11, 2020
crisbeto added a commit to crisbeto/angular that referenced this issue Feb 11, 2020
@crisbeto
fix(ivy): error if directive with synthetic property binding is on sa…
557a060 
…me node as directive that injects ViewContainerRef

In the `loadRenderer` we make an assumption that the value will always be an `LView`, but if there's a directive on the same node which injects `ViewContainerRef` the `LView` will be wrapped in an `LContainer`. These changes add a call to unwrap the value before we try to read the value off of it.

Fixes angular#35342.
@crisbeto crisbeto mentioned this issue Feb 11, 2020
Closed
@kara kara closed this as completed in d6bc63f Feb 13, 2020
kara pushed a commit that referenced this issue Feb 13, 2020
@crisbeto @kara
fix(ivy): error if directive with synthetic property binding is on sa…
a30fd29 
…me node as directive that injects ViewContainerRef (#35343)

In the `loadRenderer` we make an assumption that the value will always be an `LView`, but if there's a directive on the same node which injects `ViewContainerRef` the `LView` will be wrapped in an `LContainer`. These changes add a call to unwrap the value before we try to read the value off of it.

Fixes #35342.

PR Close #35343
@greyskulll greyskulll mentioned this issue Feb 17, 2020
Closed
sonukapoor pushed a commit to sonukapoor/angular that referenced this issue Feb 17, 2020
@crisbeto @sonukapoor
fix(ivy): error if directive with synthetic property binding is on sa…
2e586bf 
…me node as directive that injects ViewContainerRef (angular#35343)

In the `loadRenderer` we make an assumption that the value will always be an `LView`, but if there's a directive on the same node which injects `ViewContainerRef` the `LView` will be wrapped in an `LContainer`. These changes add a call to unwrap the value before we try to read the value off of it.

Fixes angular#35342.

PR Close angular#35343
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
freq2: medium regression Indicates than the issue relates to something that worked in a previous version state: has PR
Projects
None yet
Milestone
needsTriage
2 participants
@tadzik @crisbeto