Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Repetition on getting started tutorial #35290

Closed
wants to merge 1 commit into from
Closed

docs: Repetition on getting started tutorial #35290

wants to merge 1 commit into from

Conversation

santoshyadavdev
Copy link
Contributor

@santoshyadavdev santoshyadavdev commented Feb 10, 2020 •
edited

Fixes #35286

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #35286

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

aikithoughts
aikithoughts approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@aikithoughts aikithoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! LGTM!

@ngbot ngbot bot modified the milestone: Backlog Feb 11, 2020
@kapunahelewong kapunahelewong added this to Waiting for Merge in docs Feb 11, 2020
kapunahelewong
kapunahelewong approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, @santoshyadav198613!

@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label Feb 11, 2020
kara pushed a commit that referenced this pull request Feb 11, 2020
@santoshyadavdev @kara
docs: Repetition on getting started tutorial (#35290)
e19eebc 
Fixes #35286
PR Close #35290
@kara kara closed this in b9b38f0 Feb 11, 2020
@kapunahelewong kapunahelewong moved this from Waiting for Merge to Done in docs Feb 11, 2020
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
@santoshyadavdev @sonukapoor
docs: Repetition on getting started tutorial (angular#35290)
08d1b12 
Fixes angular#35286
PR Close angular#35290
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 17, 2020
@santoshyadavdev @sonukapoor
docs: Repetition on getting started tutorial (angular#35290)
8a53c80 
Fixes angular#35286
PR Close angular#35290
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kapunahelewong kapunahelewong kapunahelewong approved these changes

@aikithoughts aikithoughts aikithoughts approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Repetition on getting started tutorial on ManagingData
4 participants
@santoshyadavdev @kapunahelewong @aikithoughts @googlebot