fix(ngcc): ensure that path-mapped secondary entry-points are processed correctly #35227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed correctly The `TargetedEntryPointFinder` must work out what the containing package is for each entry-point that it finds. The logic for doing this was flawed in the case that the package was in a path-mapped directory and not in a node_modules folder. This meant that secondary entry-points were incorrectly setting their own path as the package path, rather than the primary entry-point path. Fixes angular#35188
petebacondarwin
added
type: bug/fix
action: review
alxhub
approved these changes
Feb 7, 2020
alxhub
added
action: merge
kara
pushed a commit
that referenced
this pull request
Feb 7, 2020
…ed correctly (#35227) The `TargetedEntryPointFinder` must work out what the containing package is for each entry-point that it finds. The logic for doing this was flawed in the case that the package was in a path-mapped directory and not in a node_modules folder. This meant that secondary entry-points were incorrectly setting their own path as the package path, rather than the primary entry-point path. Fixes #35188 PR Close #35227
petebacondarwin
deleted the
ngcc-targeted-dist-secondary-entry-points-35188
branch
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
…ed correctly (angular#35227) The `TargetedEntryPointFinder` must work out what the containing package is for each entry-point that it finds. The logic for doing this was flawed in the case that the package was in a path-mapped directory and not in a node_modules folder. This meant that secondary entry-points were incorrectly setting their own path as the package path, rather than the primary entry-point path. Fixes angular#35188 PR Close angular#35227
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 17, 2020
…ed correctly (angular#35227) The `TargetedEntryPointFinder` must work out what the containing package is for each entry-point that it finds. The logic for doing this was flawed in the case that the package was in a path-mapped directory and not in a node_modules folder. This meant that secondary entry-points were incorrectly setting their own path as the package path, rather than the primary entry-point path. Fixes angular#35188 PR Close angular#35227
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TargetedEntryPointFindermust work out what thecontaining package is for each entry-point that it finds.
The logic for doing this was flawed in the case that the
package was in a path-mapped directory and not in a
node_modules folder. This meant that secondary entry-points
were incorrectly setting their own path as the package
path, rather than the primary entry-point path.
Fixes #35188
Fixes #34755