Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(elements): schematics fails with schema.json not found error #35211

Closed
wants to merge 8 commits into from
Closed

fix(elements): schematics fails with schema.json not found error #35211

wants to merge 8 commits into from

Conversation

alan-agius4
Copy link
Contributor

Fixes #35154

@pullapprove pullapprove bot requested review from gkalpak and mhevery February 7, 2020 07:24
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release area: elements Issues related to Angular Elements labels Feb 7, 2020
@ngbot ngbot bot added this to the needsTriage milestone Feb 7, 2020
gkalpak
gkalpak requested changes Feb 7, 2020
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for adding the integration test 💯

Can you explain somewhere in the integration test (e.g. in a README.md or in a comment in the test script) what this test is testing. (I understand from the context that it verifies the ng-add schematic works correctly, but it would be hard to infer by only looking at the integration test.

integration/ng_elements-schematics/package.json Outdated Show resolved Hide resolved
integration/ng_elements-schematics/test.sh Outdated Show resolved Hide resolved
integration/ng_elements-schematics/package.json Outdated Show resolved Hide resolved
integration/ng_elements-schematics/test.sh Outdated Show resolved Hide resolved
gkalpak
gkalpak requested changes Feb 9, 2020
View reviewed changes
integration/ng_elements_schematics/test.ts Show resolved Hide resolved
integration/ng_elements_schematics/test.ts Outdated Show resolved Hide resolved
integration/ng_elements_schematics/test.ts Outdated Show resolved Hide resolved
integration/ng_elements_schematics/test.ts Outdated Show resolved Hide resolved
integration/ng_elements_schematics/test.ts Outdated Show resolved Hide resolved
integration/ng_elements_schematics/test.ts Outdated Show resolved Hide resolved
@alan-agius4
Copy link
Contributor Author

@gkalpak PTAL

@gkalpak gkalpak added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 10, 2020
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 10, 2020
@alan-agius4 alan-agius4 removed the request for review from mhevery February 10, 2020 17:41
@pullapprove pullapprove bot requested a review from mhevery February 10, 2020 17:41
kara pushed a commit that referenced this pull request Feb 11, 2020
@alan-agius4 @kara
fix(elements): schematics fails with schema.json not found error (#35211
94d002b 
)

Fixes #35154

PR Close #35211
@kara kara closed this in 7c9735a Feb 11, 2020
@alan-agius4 alan-agius4 deleted the element-schema-schematics branch February 11, 2020 19:53
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
@alan-agius4 @sonukapoor
fix(elements): schematics fails with schema.json not found error (ang…
ec8397c 
…ular#35211)

Fixes angular#35154

PR Close angular#35211
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 17, 2020
@alan-agius4 @sonukapoor
fix(elements): schematics fails with schema.json not found error (ang…
da93275 
…ular#35211)

Fixes angular#35154

PR Close angular#35211
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: elements Issues related to Angular Elements cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

ng add @angular/elements@next fails with schema.json not found error
4 participants
@alan-agius4 @mhevery @gkalpak @googlebot