fix(ivy): ensure module imports are instantiated before the module being declared #35172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
force-pushed
the
moduleOrder
branch
2 times, most recently
from
7798b8f
to
5539ca6
Compare
alxhub
approved these changes
Feb 6, 2020
packages/core/src/di/r3_injector.ts
Outdated
| @@ -330,6 +326,9 @@ export class R3Injector { | |||
| } | |||
| } | |||
| } | |||
| // Track the InjectorType and add a provider for it. | |||
There was a problem hiding this comment.
Add a comment here about the ordering being important - recursing into children and then adding the injectortype to the set.
| @@ -77,6 +77,25 @@ describe('NgModule', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('initializes the module imports before the module itself', () => { | |||
There was a problem hiding this comment.
This test is great, but it would be nice to have a simple r3_injector_spec test as well.
atscott
force-pushed
the
moduleOrder
branch
2 times, most recently
from
791a4bb
to
865f9ee
Compare
atscott
added
area: core
|
presubmit (failing tests passed in a rerun) |
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
…ing declared (angular#35172) PR Close angular#35172
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 17, 2020
…ing declared (angular#35172) PR Close angular#35172
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.