Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bazel): devserver shows blank page in Windows #35159

Closed
wants to merge 1 commit into from
Closed

fix(bazel): devserver shows blank page in Windows #35159

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Feb 5, 2020 •
edited

@pullapprove pullapprove bot requested a review from kyliau February 5, 2020 08:26
@alan-agius4 alan-agius4 added area: bazel Issues related to the published `@angular/bazel` build rules target: patch This PR is targeted for the next patch release labels Feb 5, 2020
@ngbot ngbot bot added this to the needsTriage milestone Feb 5, 2020
kyliau
kyliau approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@kyliau kyliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any idea why it works fine on linux without this change but not on windows?

@alan-agius4
Copy link
Contributor Author

@kyliau not really maybe @gregmagolan would know!

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 5, 2020
@ngbot
Copy link

ngbot bot commented Feb 5, 2020

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing
    failure status "ci/circleci: saucelabs_ivy" is failing
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

mhevery pushed a commit that referenced this pull request Feb 6, 2020
@alan-agius4 @mhevery
fix(bazel): devserver shows blank page in Windows (#35159)
727f92f 
`additional_root_paths` should contain the workspace name see: https://github.com/bazelbuild/rules_nodejs/blob/d4200191c5fb84f395311840d8f90d3715e9f751/packages/typescript/src/internal/devserver/ts_devserver.bzl#L137-L140

Fixes #35144

PR Close #35159
@mhevery mhevery closed this in 129010e Feb 6, 2020
@alan-agius4 alan-agius4 deleted the bazel-dev-windows branch February 7, 2020 06:37
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
@alan-agius4 @sonukapoor
fix(bazel): devserver shows blank page in Windows (angular#35159)
dc8df64 
`additional_root_paths` should contain the workspace name see: https://github.com/bazelbuild/rules_nodejs/blob/d4200191c5fb84f395311840d8f90d3715e9f751/packages/typescript/src/internal/devserver/ts_devserver.bzl#L137-L140

Fixes angular#35144

PR Close angular#35159
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 17, 2020
@alan-agius4 @sonukapoor
fix(bazel): devserver shows blank page in Windows (angular#35159)
ca3042d 
`additional_root_paths` should contain the workspace name see: https://github.com/bazelbuild/rules_nodejs/blob/d4200191c5fb84f395311840d8f90d3715e9f751/packages/typescript/src/internal/devserver/ts_devserver.bzl#L137-L140

Fixes angular#35144

PR Close angular#35159
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyliau kyliau kyliau approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

additional_root_paths in ts_devserver should contain workspace name
3 participants
@alan-agius4 @kyliau @googlebot