fix(ivy): LFrame needs to release memory on leaveView()
#35156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
comp: ivy
action: review
mhevery
force-pushed
the
issue-35148
branch
3 times, most recently
from
d6fd7d5
to
ceb6373
Compare
pkozlowski-opensource
requested changes
Feb 12, 2020
There was a problem hiding this comment.
The code LGTM but I'm surprised that there is code size increase (and it is even bigger than what is written in the code as the CI check fails: https://circleci.com/gh/angular/angular/621857#tests/containers/3)
I think this is the case where the limit was close to 500 bytes and this CL took os over, so now you have the 500 bytes plus this CL. |
pkozlowski-opensource
approved these changes
Feb 12, 2020
kara
added
action: cleanup
mhevery
added
action: merge
Root cause is that for perf reasons we cache `LFrame` so that we don't have to allocate it all the time. To be extra fast we clear the `LFrame` on `enterView()` rather that on `leaveView()`. The implication of this strategy is that the deepest `LFrame` will retain objects until the `LFrame` allocation depth matches the deepest object. The fix is to simply clear the `LFrame` on `leaveView()` rather then on `enterView()` Fix angular#35148
alxhub
pushed a commit
that referenced
this pull request
Feb 14, 2020
Root cause is that for perf reasons we cache `LFrame` so that we don't have to allocate it all the time. To be extra fast we clear the `LFrame` on `enterView()` rather that on `leaveView()`. The implication of this strategy is that the deepest `LFrame` will retain objects until the `LFrame` allocation depth matches the deepest object. The fix is to simply clear the `LFrame` on `leaveView()` rather then on `enterView()` Fix #35148 PR Close #35156
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 17, 2020
…35156) Root cause is that for perf reasons we cache `LFrame` so that we don't have to allocate it all the time. To be extra fast we clear the `LFrame` on `enterView()` rather that on `leaveView()`. The implication of this strategy is that the deepest `LFrame` will retain objects until the `LFrame` allocation depth matches the deepest object. The fix is to simply clear the `LFrame` on `leaveView()` rather then on `enterView()` Fix angular#35148 PR Close angular#35156
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause is that for perf reasons we cache
LFrameso that we don't have to allocate it all the time. To be extra fast we clear theLFrameonenterView()rather that onleaveView(). The implication of this strategy is that the deepestLFramewill retain objects until theLFrameallocation depth matches the deepest object.The fix is to simply clear the
LFrameonleaveView()rather then onenterView()Fix #35148
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information