fix(ivy): template type-check errors from TS should not use NG error codes #35146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxhub
changed the title
alxhub
added
action: merge
AndrewKushnir
approved these changes
Feb 4, 2020
…codes A bug previously caused the template type-checking diagnostics produced by TypeScript for template expressions to use -99-prefixed error codes. These codes are converted to "NG" errors instead of "TS" errors during diagnostic printing. This commit fixes the issue.
alxhub
force-pushed
the
ngtsc/ttc/error-code
branch
from
35abbf3
to
66565f1
Compare
mhevery
added
the
area: compiler
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
…codes (angular#35146) A bug previously caused the template type-checking diagnostics produced by TypeScript for template expressions to use -99-prefixed error codes. These codes are converted to "NG" errors instead of "TS" errors during diagnostic printing. This commit fixes the issue. PR Close angular#35146
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 17, 2020
…codes (angular#35146) A bug previously caused the template type-checking diagnostics produced by TypeScript for template expressions to use -99-prefixed error codes. These codes are converted to "NG" errors instead of "TS" errors during diagnostic printing. This commit fixes the issue. PR Close angular#35146
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug previously caused the template type-checking diagnostics produced by
TypeScript for template expressions to use -99-prefixed error codes. These
codes are converted to "NG" errors instead of "TS" errors during diagnostic
printing. This commit fixes the issue.