fix(ivy): set namespace for host elements of dynamically created components #35136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
type: bug/fix
target: patch
This was referenced Feb 4, 2020
kara
requested changes
Feb 4, 2020
|
Hi @kara, thanks for the review! I performed additional changes based on your feedback. Could you pleaser have another look when you get a chance? Thank you. |
…onents Prior to this change, element namespace was not set for host elements of dynamically created components that resulted in incorrect rendering in a browser. This commit adds the logic to pick and set correct namespace for host element when component is created dynamically.
AndrewKushnir
force-pushed
the
namespace-for-dynamic-component-host
branch
from
12b83e1
to
b132e5d
Compare
AndrewKushnir
added
the
action: presubmit
3 tasks
kara
approved these changes
Feb 8, 2020
| @@ -174,7 +174,7 @@ class DefaultDomRenderer2 implements Renderer2 { | |||
| setAttribute(el: any, name: string, value: string, namespace?: string): void { | |||
| if (namespace) { | |||
| name = namespace + ':' + name; | |||
| // TODO(benlesh): Ivy may cause issues here because it's passing around | |||
| // TODO(FW-811): Ivy may cause issues here because it's passing around | |||
kara
pushed a commit
that referenced
this pull request
Feb 8, 2020
…onents (#35136) Prior to this change, element namespace was not set for host elements of dynamically created components that resulted in incorrect rendering in a browser. This commit adds the logic to pick and set correct namespace for host element when component is created dynamically. PR Close #35136
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
…onents (angular#35136) Prior to this change, element namespace was not set for host elements of dynamically created components that resulted in incorrect rendering in a browser. This commit adds the logic to pick and set correct namespace for host element when component is created dynamically. PR Close angular#35136
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 17, 2020
…onents (angular#35136) Prior to this change, element namespace was not set for host elements of dynamically created components that resulted in incorrect rendering in a browser. This commit adds the logic to pick and set correct namespace for host element when component is created dynamically. PR Close angular#35136
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, element namespace was not set for host elements of dynamically created components that resulted in incorrect rendering in a browser. This commit adds the logic to pick and set correct namespace for host element when component is created dynamically.
Fixes #34256, #34866.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?