-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(benchpress): added tsconfig and fixed ts errors #35127
Conversation
Side noteIt would be nice to reduce or even eliminate our usage of @types/jasminewd2 from our repo since it is severely outdated -- it's last publish was 2 years ago. See https://www.npmjs.com/package/jasminewd2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What is the current behavior?
modules/benchmarks
was not getting ts checked properly.What is the new behavior?
modules/benchmarks
has it's own tsconfig now, which should help alleviate some of the divergence between internal and external benchpress tests.Does this PR introduce a breaking change?