Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(benchpress): added tsconfig and fixed ts errors #35127

Closed
wants to merge 2 commits into from

Conversation

wagnermaciel
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

modules/benchmarks was not getting ts checked properly.

What is the new behavior?

modules/benchmarks has it's own tsconfig now, which should help alleviate some of the divergence between internal and external benchpress tests.

Does this PR introduce a breaking change?

  • Yes
  • No

@wagnermaciel wagnermaciel marked this pull request as ready for review February 3, 2020 20:42
@wagnermaciel
Copy link
Contributor Author

Side note

It would be nice to reduce or even eliminate our usage of @types/jasminewd2 from our repo since it is severely outdated -- it's last publish was 2 years ago. See https://www.npmjs.com/package/jasminewd2

@mhevery mhevery added area: benchpress action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 4, 2020
@ngbot ngbot bot modified the milestone: needsTriage Feb 4, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhevery mhevery closed this in e210715 Feb 4, 2020
mhevery pushed a commit that referenced this pull request Feb 4, 2020
mhevery pushed a commit that referenced this pull request Feb 4, 2020
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 17, 2020
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 17, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: benchpress cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants