Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on Bazel does not work #35107

Closed
chris-house opened this issue Feb 2, 2020 · 6 comments
Closed

Documentation on Bazel does not work #35107

chris-house opened this issue Feb 2, 2020 · 6 comments

Comments

@chris-house
Copy link

chris-house commented Feb 2, 2020

馃摎 Docs or angular.io bug report

Description

A clear and concise description of the problem...

I want to use bazel on a new project with angular 8 or add it to an existing project

馃敩 Minimal Reproduction

ng new --collection=@angular/bazel
This is enough to give me the error

What's the affected URL?**

https://angular.io/...

https://angular.io/guide/bazel

Reproduction Steps**

Run Cmd
type in ng new --collection=@angular/bazel

Expected vs Actual Behavior**

image
H:\angular>ng new --collection=@angular/bazel
Schematic "application" not found in collection "@angular/bazel".
Error: Schematic "application" not found in collection "@angular/bazel".
at SchematicEngine.createSchematic (C:\Users\Chris\AppData\Roaming\npm\node_modules@angular\cli\node_modules@angular-devkit\schematics\src\engine\engine.js:155:23)
at CollectionImpl.createSchematic (C:\Users\Chris\AppData\Roaming\npm\node_modules@angular\cli\node_modules@angular-devkit\schematics\src\engine\collection.js:12:29)
at Object.getSchematic (C:\Users\Chris\AppData\Roaming\npm\node_modules@angular\cli\utilities\schematics.js:36:23)
at NewCommand.getOptions (C:\Users\Chris\AppData\Roaming\npm\node_modules@angular\cli\models\schematic-command.js:195:40)
at NewCommand.initialize (C:\Users\Chris\AppData\Roaming\npm\node_modules@angular\cli\commands\new.js:48:21)
at Object. (C:\Users\Chris\AppData\Roaming\npm\node_modules@angular\cli\models\command-runner.js:87:23)
at Generator.next ()
at fulfilled (C:\Users\Chris\AppData\Roaming\npm\node_modules@angular\cli\models\command-runner.js:4:58)

馃摲Screenshot

馃實 Your Environment

Windows 10

Browser info

chrome

Anything else relevant?

When trying to add bazel to an existing application, I faced a number of issues when trying to follow the 'documentation' on Angular.Io

For example, as of now, I need bash installed on windows.

set PATH=C:\msys64\usr\bin;%PATH% set BAZEL_SH=C:\msys64\usr\bin\bash.exe
If not I get this error:
image

Maybe have a disclaimer that it wont be very easy to get custom material theme to work:
bazelbuild/rules_sass#98

I was unable to use yarn and had to switch to npm on existing angular application when trying to build with bazel.
#30350

In the angular-metadata.tsconfig.json I had to add the line to exclude @angular/cli

    "node_modules/@angular/cli/**",
    "node_modules/@angular/bazel/**",
    "node_modules/@angular/**/schematics/**",
    "node_modules/@angular/**/testing/**",
    "node_modules/@angular/compiler-cli/**",
    "node_modules/@angular/common/upgrade*",
    "node_modules/@angular/router/upgrade*"
  ]```
@manklu
Copy link

manklu commented Feb 2, 2020

@crh225 There are several open issues with bazel on windows.

IMO its currently the best to use WSL 2 for bazel.
https://docs.microsoft.com/en-us/windows/wsl/wsl2-index

@chris-house
Copy link
Author

The bash script is one point of many of bazel not working is my point. The documentation, as is, makes it seem like it takes 5 minutes or less to enable bazel.

@kapunahelewong
Copy link
Contributor

Status: Docs Team needs engineering input to know how to document bazel implementation correctly.

@chris-house
Copy link
Author

@kyliau
Copy link
Contributor

kyliau commented Jul 22, 2020

Bazel support in @angular/angular has been deprecated in version 10.
As part of the cleanup, we now redirect https://angular.io/guide/bazel to the migration doc.
The Bazel effort is now wholly owned by the Bazel community.
As mentioned in the migration doc, if you need help, please reach out to folks in the #angular channel in http://slack.bazel.build/

@kyliau kyliau closed this as completed Jul 22, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
docs
Need Assistance from Eng.
Development

No branches or pull requests

5 participants