Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in the router animation docs #35100

Closed
wants to merge 1 commit into from

Conversation

mprinc
Copy link
Contributor

@mprinc mprinc commented Feb 1, 2020

docs(animations): typo in the router animation docs

I assume that instead of output directive there should have been written: outlet directive

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • [x ] Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • [x ] No

Other information

@pullapprove pullapprove bot requested a review from matsko February 1, 2020 15:40
@ngbot ngbot bot modified the milestone: Backlog Feb 3, 2020
@kapunahelewong
Copy link
Contributor

Thanks for this, @mprinc. Do you have a preference as to which of these two PRs we use?

@mprinc
Copy link
Contributor Author

mprinc commented Feb 3, 2020

Hi @kapunahelewong , I do not see another PR at the moment, but the only difference should be in the comment section, the latest one should be more according to the angular specs, otherwise, I do not mind

@kapunahelewong kapunahelewong added this to Committed - Selected for development in docs Feb 4, 2020
@kapunahelewong kapunahelewong moved this from Committed - Selected for development to In Review in docs Feb 4, 2020
@kapunahelewong
Copy link
Contributor

Ah, I meant this one: #35099. As they are identical, we can move this one forward and I'll close the other. Thank you very much!

merge-assistance: Global approval for this docs-only change.

@kapunahelewong kapunahelewong moved this from In Review to Waiting for Merge in docs Feb 4, 2020
@mprinc
Copy link
Contributor Author

mprinc commented Feb 4, 2020

Yes, @kapunahelewong, that is right, the #35100 just corrected title of the #35099

`output directive` should be written: `outlet directive`
@kapunahelewong kapunahelewong changed the title docs(animations): typo in the router animation docs docs: fix typo in the router animation docs Feb 4, 2020
@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label Feb 4, 2020
mhevery pushed a commit that referenced this pull request Feb 4, 2020
`output directive` should be written: `outlet directive`

PR Close #35100
@mhevery mhevery closed this in 1f6da8c Feb 4, 2020
@kapunahelewong kapunahelewong moved this from Waiting for Merge to Done in docs Feb 5, 2020
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
`output directive` should be written: `outlet directive`

PR Close angular#35100
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 17, 2020
`output directive` should be written: `outlet directive`

PR Close angular#35100
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2020
@mprinc mprinc deleted the patch-2 branch March 9, 2020 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants