-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typo in the router animation docs #35100
Conversation
Thanks for this, @mprinc. Do you have a preference as to which of these two PRs we use? |
Hi @kapunahelewong , I do not see another PR at the moment, but the only difference should be in the comment section, the latest one should be more according to the angular specs, otherwise, I do not mind |
Ah, I meant this one: #35099. As they are identical, we can move this one forward and I'll close the other. Thank you very much! merge-assistance: Global approval for this docs-only change. |
Yes, @kapunahelewong, that is right, the #35100 just corrected title of the #35099 |
2d451d4
to
478a24f
Compare
`output directive` should be written: `outlet directive`
478a24f
to
028b9cc
Compare
`output directive` should be written: `outlet directive` PR Close #35100
`output directive` should be written: `outlet directive` PR Close angular#35100
`output directive` should be written: `outlet directive` PR Close angular#35100
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
docs(animations): typo in the router animation docs
I assume that instead of
output directive
there should have been written:outlet directive
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information