Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(animations): increase wait time for status-slider animation #35089

Closed
wants to merge 2 commits into from
Closed

docs(animations): increase wait time for status-slider animation #35089

wants to merge 2 commits into from

Conversation

josephperrott
Copy link
Member

@josephperrott josephperrott commented Jan 31, 2020 •
edited

Because the animation completes in 2000ms, and browser.wait checks
every 100ms, there can be a race condition of if the final state has
actually been reached to read the color. By moving to 2101ms, we ensure
that we check after the 2000ms of the animation has completed.

Fixes #35038

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker area: animations target: patch This PR is targeted for the next patch release labels Jan 31, 2020
@ngbot ngbot bot modified the milestone: needsTriage Jan 31, 2020
@pullapprove pullapprove bot requested a review from matsko January 31, 2020 22:56
@josephperrott josephperrott requested review from IgorMinar and removed request for matsko January 31, 2020 22:57
@josephperrott
Copy link
Member Author

Setting @IgorMinar as reviewer as @matsko is out today

IgorMinar
IgorMinar approved these changes Feb 1, 2020
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for the commit message which should have been test(animations): ...

"docs:" is for docs only content - https://github.com/angular/angular/blob/master/CONTRIBUTING.md#type

@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 1, 2020
@IgorMinar
Copy link
Contributor

as discussed in person, we could argue that this is a primarily "docs" change.

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Feb 1, 2020
@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot added cla: no and removed cla: yes labels Feb 4, 2020
@gkalpak

This comment has been minimized.

Sign in to view
@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot added cla: yes and removed cla: no labels Feb 4, 2020
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 4, 2020
josephperrott and others added 2 commits February 4, 2020 23:34
@josephperrott @gkalpak
docs(animations): increase wait time for status-slider animation
d839ad2 
Because the animation completes in 2000ms, and browser.wait checks
every 100ms, there can be a race condition of if the final state has
actually been reached to read the color. By moving to 2101ms, we ensure
that we cheack after the 2000ms of the animation has completed.
@gkalpak
fixup! docs(animations): increase wait time for status-slider animation
ef4c83e
@ngbot
Copy link

ngbot bot commented Feb 4, 2020

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: setup" is failing
    pending missing required status "ci/circleci: build"
    pending missing required status "ci/circleci: lint"
    pending missing required status "ci/circleci: publish_snapshot"
    pending missing required status "ci/angular: size"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

mhevery pushed a commit that referenced this pull request Feb 4, 2020
@josephperrott @mhevery
docs(animations): increase wait time for status-slider animation (#35089
d5eada6 
)

Because the animation completes in 2000ms, and browser.wait checks
every 100ms, there can be a race condition of if the final state has
actually been reached to read the color. By moving to 2101ms, we ensure
that we cheack after the 2000ms of the animation has completed.

PR Close #35089
@mhevery mhevery closed this in 960e5e2 Feb 4, 2020
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
@josephperrott @sonukapoor
docs(animations): increase wait time for status-slider animation (ang…
7703ee1 
…ular#35089)

Because the animation completes in 2000ms, and browser.wait checks
every 100ms, there can be a race condition of if the final state has
actually been reached to read the color. By moving to 2101ms, we ensure
that we cheack after the 2000ms of the animation has completed.

PR Close angular#35089
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 17, 2020
@josephperrott @sonukapoor
docs(animations): increase wait time for status-slider animation (ang…
630ea6b 
…ular#35089)

Because the animation completes in 2000ms, and browser.wait checks
every 100ms, there can be a race condition of if the final state has
actually been reached to read the color. By moving to 2101ms, we ensure
that we cheack after the 2000ms of the animation has completed.

PR Close angular#35089
@josephperrott josephperrott deleted the test_docs_example_flake branch February 28, 2020 17:29
@josephperrott josephperrott mentioned this pull request Feb 28, 2020
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: animations cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

ci: test_docs_examples job is flakey
4 participants
@josephperrott @IgorMinar @googlebot @gkalpak