Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): add sass as a valid css preprocessor extension #35052

Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): add sass as a valid css preprocessor extension #35052

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Jan 30, 2020

.sass is a valid preprocessor extension which is used for Sass indented syntax

https://sass-lang.com/documentation/syntax

@pullapprove pullapprove bot requested a review from JoostK January 30, 2020 11:03
@alan-agius4 alan-agius4 added the area: compiler Issues related to `ngc`, Angular's template compiler label Jan 30, 2020
@ngbot ngbot bot added this to the needsTriage milestone Jan 30, 2020
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jan 30, 2020
`.sass` is a valid preprocessor extension which is used for Sass indented syntax

https://sass-lang.com/documentation/syntax
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit labels Jan 31, 2020
@AndrewKushnir
Copy link
Contributor

Presubmit

@josephperrott josephperrott removed the request for review from JoostK January 31, 2020 20:58
@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Jan 31, 2020
mhevery pushed a commit that referenced this pull request Jan 31, 2020
…35052)

`.sass` is a valid preprocessor extension which is used for Sass indented syntax

https://sass-lang.com/documentation/syntax

PR Close #35052
@mhevery mhevery closed this in 6d11a81 Jan 31, 2020
@alan-agius4 alan-agius4 deleted the compiler-sass branch January 31, 2020 22:09
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
…ngular#35052)

`.sass` is a valid preprocessor extension which is used for Sass indented syntax

https://sass-lang.com/documentation/syntax

PR Close angular#35052
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants