fix(ivy): ensure `DebugNode`/`DebugElement` are tree-shakeable in Ivy #35003

gkalpak · 2020-01-28T12:19:50Z

There are different DebugNode/DebugElement implementations (and associated helper functions) for ViewEngine and Ivy. Additionally, these classes/functions, which are defined inside the core package, are imported by the platform-browser package.

Previously, this code was not tree-shaken as expected in Ivy. #30130 partially addressed the issue, but only for the case where core and platform-browser end up in the same closure after webpack's scope hoisting. In cases where this is not the case, our webpack/terser based tooling is not capable of tree-shaking it.

This commit fixes the problem, by ensuring that the code retained in Ivy mode (due to the cross-package import) does not unnecessarily reference DebugNode/DebugElement, allowing the code to be tree-shaken away. This results in a 7.6KB reduction in the size of the main angular.io
bundle.

Jira issue: FW-1802

mary-poppins · 2020-01-28T12:31:42Z

You can preview a50c40e at https://pr35003-a50c40e.ngbuilds.io/.

mary-poppins · 2020-01-28T13:26:48Z

You can preview 02e8ef6 at https://pr35003-02e8ef6.ngbuilds.io/.

gkalpak · 2020-01-28T14:41:56Z

packages/core/src/debug/debug_node.ts

+  return null;
+}
+
+export const getDebugNodeR2: (nativeNode: any) => DebugNode | null = getDebugNodeR2__PRE_R3__;


Not sure what would be an appropriate name 😇

mary-poppins · 2020-01-28T14:55:30Z

You can preview 3fccd85 at https://pr35003-3fccd85.ngbuilds.io/.

There are different `DebugNode`/`DebugElement` implementations (and associated helper functions) for ViewEngine and Ivy. Additionally, these classes/functions, which are defined inside the `core` package, are imported by the `platform-browser` package. Previously, this code was not tree-shaken as expected in Ivy. angular#30130 partially addressed the issue, but only for the case where `core` and `platform-browser` end up in the same closure after webpack's scope hoisting. In cases where this is not the case, our webpack/terser based tooling is not capable of tree-shaking it. This commit fixes the problem, by ensuring that the code retained in Ivy mode (due to the cross-package import) does not unnecessarily reference `DebugNode`/`DebugElement`, allowing the code to be tree-shaken away. This results in a 7.6KB reduction in the size of the main angular.io bundle. Jira issue: [FW-1802](https://angular-team.atlassian.net/browse/FW-1802)

mary-poppins · 2020-01-28T16:48:22Z

You can preview 9c7d3dd at https://pr35003-9c7d3dd.ngbuilds.io/.

IgorMinar

George, you rock!

thanks for figuring this out.

❤️

IgorMinar · 2020-01-28T21:10:48Z

aio/scripts/_payload-limits.json

@@ -12,7 +12,7 @@
    "master": {
      "uncompressed": {
        "runtime-es2015": 2987,
-        "main-es2015": 456604,
+        "main-es2015": 448956,


IgorMinar · 2020-01-28T21:11:26Z

integration/_payload-limits.json

@@ -39,7 +39,7 @@
    "master": {
      "uncompressed": {
        "runtime-es2015": 2289,
-        "main-es2015": 254657,
+        "main-es2015": 247225,


IgorMinar · 2020-01-28T21:16:17Z

packages/core/src/debug/debug_node.ts

+  return null;
+}
+
+export const getDebugNodeR2: (nativeNode: any) => DebugNode | null = getDebugNodeR2__PRE_R3__;


PR Close #35003

…#35003) There are different `DebugNode`/`DebugElement` implementations (and associated helper functions) for ViewEngine and Ivy. Additionally, these classes/functions, which are defined inside the `core` package, are imported by the `platform-browser` package. Previously, this code was not tree-shaken as expected in Ivy. #30130 partially addressed the issue, but only for the case where `core` and `platform-browser` end up in the same closure after webpack's scope hoisting. In cases where this is not the case, our webpack/terser based tooling is not capable of tree-shaking it. This commit fixes the problem, by ensuring that the code retained in Ivy mode (due to the cross-package import) does not unnecessarily reference `DebugNode`/`DebugElement`, allowing the code to be tree-shaken away. This results in a 7.6KB reduction in the size of the main angular.io bundle. Jira issue: [FW-1802](https://angular-team.atlassian.net/browse/FW-1802) PR Close #35003

PR Close #35003

…#35003) There are different `DebugNode`/`DebugElement` implementations (and associated helper functions) for ViewEngine and Ivy. Additionally, these classes/functions, which are defined inside the `core` package, are imported by the `platform-browser` package. Previously, this code was not tree-shaken as expected in Ivy. #30130 partially addressed the issue, but only for the case where `core` and `platform-browser` end up in the same closure after webpack's scope hoisting. In cases where this is not the case, our webpack/terser based tooling is not capable of tree-shaking it. This commit fixes the problem, by ensuring that the code retained in Ivy mode (due to the cross-package import) does not unnecessarily reference `DebugNode`/`DebugElement`, allowing the code to be tree-shaken away. This results in a 7.6KB reduction in the size of the main angular.io bundle. Jira issue: [FW-1802](https://angular-team.atlassian.net/browse/FW-1802) PR Close #35003

PR Close angular#35003

…angular#35003) There are different `DebugNode`/`DebugElement` implementations (and associated helper functions) for ViewEngine and Ivy. Additionally, these classes/functions, which are defined inside the `core` package, are imported by the `platform-browser` package. Previously, this code was not tree-shaken as expected in Ivy. angular#30130 partially addressed the issue, but only for the case where `core` and `platform-browser` end up in the same closure after webpack's scope hoisting. In cases where this is not the case, our webpack/terser based tooling is not capable of tree-shaking it. This commit fixes the problem, by ensuring that the code retained in Ivy mode (due to the cross-package import) does not unnecessarily reference `DebugNode`/`DebugElement`, allowing the code to be tree-shaken away. This results in a 7.6KB reduction in the size of the main angular.io bundle. Jira issue: [FW-1802](https://angular-team.atlassian.net/browse/FW-1802) PR Close angular#35003

angular-automatic-lock-bot · 2020-02-29T16:08:26Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

refactor: remove unused imports

eb1c9b0

googlebot added the cla: yes label Jan 28, 2020

gkalpak force-pushed the fix-remove-DebugElement branch from a50c40e to 02e8ef6 Compare January 28, 2020 13:17

gkalpak changed the title ~~Fix remove debug element~~ fix(ivy): ensure DebugNode/DebugElement are tree-shakeable in Ivy Jan 28, 2020

ngbot bot modified the milestone: needsTriage Jan 28, 2020

gkalpak added 2 commits January 28, 2020 16:35

refactor(core): order private exports alphabetically

bbb0aa6

ci(docs-infra): update payload size limits

545004e

gkalpak force-pushed the fix-remove-DebugElement branch from 02e8ef6 to 47710b0 Compare January 28, 2020 14:36

gkalpak commented Jan 28, 2020

View reviewed changes

gkalpak force-pushed the fix-remove-DebugElement branch from 47710b0 to 3fccd85 Compare January 28, 2020 14:44

gkalpak force-pushed the fix-remove-DebugElement branch from 0bd5ed3 to 9c7d3dd Compare January 28, 2020 16:37

gkalpak marked this pull request as ready for review January 28, 2020 17:12

gkalpak requested review from a team as code owners January 28, 2020 17:12

gkalpak requested a review from a team January 28, 2020 17:12

IgorMinar approved these changes Jan 28, 2020

View reviewed changes

IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 28, 2020

IgorMinar removed the request for review from a team January 28, 2020 21:19

AndrewKushnir closed this in 9e351b8 Jan 28, 2020

AndrewKushnir pushed a commit that referenced this pull request Jan 28, 2020

refactor(core): order private exports alphabetically (#35003)

0f02e66

PR Close #35003

AndrewKushnir pushed a commit that referenced this pull request Jan 28, 2020

ci(docs-infra): update payload size limits (#35003)

c8eb164

PR Close #35003

AndrewKushnir pushed a commit that referenced this pull request Jan 28, 2020

refactor: remove unused imports (#35003)

d4857e4

PR Close #35003

AndrewKushnir pushed a commit that referenced this pull request Jan 28, 2020

refactor(core): order private exports alphabetically (#35003)

900f8c8

PR Close #35003

AndrewKushnir pushed a commit that referenced this pull request Jan 28, 2020

ci(docs-infra): update payload size limits (#35003)

9ccf181

PR Close #35003

gkalpak deleted the fix-remove-DebugElement branch January 29, 2020 10:01

sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020

refactor: remove unused imports (angular#35003)

df51bf5

PR Close angular#35003

sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020

refactor(core): order private exports alphabetically (angular#35003)

76abdc6

PR Close angular#35003

sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020

ci(docs-infra): update payload size limits (angular#35003)

ad6e86d

PR Close angular#35003

angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ivy): ensure `DebugNode`/`DebugElement` are tree-shakeable in Ivy #35003

fix(ivy): ensure `DebugNode`/`DebugElement` are tree-shakeable in Ivy #35003

gkalpak commented Jan 28, 2020 •

edited

mary-poppins commented Jan 28, 2020

mary-poppins commented Jan 28, 2020

gkalpak Jan 28, 2020

IgorMinar Jan 28, 2020

mary-poppins commented Jan 28, 2020

mary-poppins commented Jan 28, 2020

IgorMinar left a comment •

edited

IgorMinar Jan 28, 2020

IgorMinar Jan 28, 2020

IgorMinar Jan 28, 2020

angular-automatic-lock-bot bot commented Feb 29, 2020

fix(ivy): ensure DebugNode/DebugElement are tree-shakeable in Ivy #35003

fix(ivy): ensure DebugNode/DebugElement are tree-shakeable in Ivy #35003

Conversation

gkalpak commented Jan 28, 2020 • edited

mary-poppins commented Jan 28, 2020

mary-poppins commented Jan 28, 2020

gkalpak Jan 28, 2020

Choose a reason for hiding this comment

IgorMinar Jan 28, 2020

Choose a reason for hiding this comment

mary-poppins commented Jan 28, 2020

mary-poppins commented Jan 28, 2020

IgorMinar left a comment • edited

Choose a reason for hiding this comment

IgorMinar Jan 28, 2020

Choose a reason for hiding this comment

IgorMinar Jan 28, 2020

Choose a reason for hiding this comment

IgorMinar Jan 28, 2020

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Feb 29, 2020

fix(ivy): ensure `DebugNode`/`DebugElement` are tree-shakeable in Ivy #35003

fix(ivy): ensure `DebugNode`/`DebugElement` are tree-shakeable in Ivy #35003

gkalpak commented Jan 28, 2020 •

edited

IgorMinar left a comment •

edited