Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ngcc): improve lockfile error message #35001

Closed

Conversation

petebacondarwin
Copy link
Member

The message now gives concrete advice to developers who
experience the error due to running multiple simultaneous builds
via webpack.

Fixes #35000

@petebacondarwin petebacondarwin added type: bug/fix comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 28, 2020
@petebacondarwin petebacondarwin requested a review from a team as a code owner January 28, 2020 10:15
@ngbot ngbot bot modified the milestone: needsTriage Jan 28, 2020
The message now gives concrete advice to developers who
experience the error due to running multiple simultaneous builds
via webpack.

Fixes angular#35000
@gkalpak gkalpak added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 28, 2020
@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 28, 2020
AndrewKushnir pushed a commit that referenced this pull request Jan 28, 2020
The message now gives concrete advice to developers who
experience the error due to running multiple simultaneous builds
via webpack.

Fixes #35000

PR Close #35001
@petebacondarwin petebacondarwin deleted the ngcc-lockfile-message branch January 29, 2020 10:23
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
The message now gives concrete advice to developers who
experience the error due to running multiple simultaneous builds
via webpack.

Fixes angular#35000

PR Close angular#35001
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying custom NGCC lockfile location (cannot build in parallel with Ivy)
3 participants