fix(localize): re-enable filename in code-frame error messages #34994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were removed in 4c3a543 due to a breaking change in an update to `babel-core`. See babel/babel@dcf7d89 This commit adds back in the filename to these messages. Resolves https://github.com/angular/angular/pull/34974/files#r371034476
petebacondarwin
added
type: bug/fix
action: merge
petebacondarwin
removed
the
action: review
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 27, 2020
These were removed in 4c3a543 due to a breaking change in an update to `babel-core`. See babel/babel@dcf7d89 This commit adds back in the filename to these messages. Resolves https://github.com/angular/angular/pull/34974/files#r371034476 PR Close #34994
|
Thanks Pete! |
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
…ar#34994) These were removed in 4c3a543 due to a breaking change in an update to `babel-core`. See babel/babel@dcf7d89 This commit adds back in the filename to these messages. Resolves https://github.com/angular/angular/pull/34974/files#r371034476 PR Close angular#34994
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were removed in 4c3a543 due to a breaking change in an update to
babel-core.See babel/babel@dcf7d89.
This commit adds back in the filename to these messages.
Resolves https://github.com/angular/angular/pull/34974/files#r371034476