feat(common): expose getLocaleCurrencyCode publicly #34946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously defined in core without being exposed publicly, whereas `getLocaleCurrencyName` and `getLocaleCurrencySymbol` were defined in common, and publicly exposed. This commit now privately exposes `ɵgetLocaleCurrencyCode` from core, and reexports it publicly from common.
petebacondarwin
added
area: i18n
PR target: patch-only
feature
petebacondarwin
approved these changes
Jan 24, 2020
petebacondarwin
added
action: presubmit
AndrewKushnir
removed
the
action: presubmit
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 24, 2020
It was previously defined in core without being exposed publicly, whereas `getLocaleCurrencyName` and `getLocaleCurrencySymbol` were defined in common, and publicly exposed. This commit now privately exposes `ɵgetLocaleCurrencyCode` from core, and reexports it publicly from common. PR Close #34946
|
Thanks @cexbrayat, this PR is now merged into the patch branch. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch-only version of #34810 as requested by @AndrewKushnir as the merge only succeeded on master (see #34810 (comment))