Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-service): Make metadata in Declaration non-optional #34936

Closed
wants to merge 1 commit into from
Closed

fix(language-service): Make metadata in Declaration non-optional #34936

wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Jan 23, 2020

The metadata field in Declaration should not be optional.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau
fix(language-service): Make metadata in Declaration non-optional
61be524 
The `metadata` field in `Declaration` should not be optional.
@kyliau kyliau added area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release labels Jan 23, 2020
@kyliau kyliau requested a review from a team as a code owner January 23, 2020 21:02
@ngbot ngbot bot modified the milestone: needsTriage Jan 23, 2020
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Jan 23, 2020
AndrewKushnir pushed a commit that referenced this pull request Jan 23, 2020
@kyliau @AndrewKushnir
fix(language-service): Make metadata in Declaration non-optional (#34936
37727ce 
)

The `metadata` field in `Declaration` should not be optional.

PR Close #34936
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020
@kyliau @sonukapoor
fix(language-service): Make metadata in Declaration non-optional (ang…
229dabd 
…ular#34936)

The `metadata` field in `Declaration` should not be optional.

PR Close angular#34936
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 23, 2020
@kyliau kyliau deleted the declaration branch September 30, 2020 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ayazhafiz ayazhafiz ayazhafiz approved these changes

Assignees

@ayazhafiz ayazhafiz

Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyliau @ayazhafiz @googlebot