fix(ivy): ensure multi providers in ModuleWithProviders are not duplicated #34914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
comp: ivy
area: testing
|
Presubmit - looks good, only failing tests are e2e tests, which are not affected by this change and are probably flakes. Still need to run global presubmit |
atscott
force-pushed
the
testbedmultiprovider
branch
3 times, most recently
from
45b0109
to
96c29ef
Compare
|
global presubmit 1 regressed e2e test, unrelated to this change. |
…cated The current logic pulls multiproviders up to the parent module's provider list. The result is that the multi provider being defined both in the imported ModuleWithProviders and the parent and getting an extra item in the multi provided array of values. This PR fixes that problem by not pulling providers in ModuleWithProviders up to the parent module.
atscott
force-pushed
the
testbedmultiprovider
branch
from
96c29ef
to
e89938b
Compare
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 29, 2020
…cated (#34914) The current logic pulls multiproviders up to the parent module's provider list. The result is that the multi provider being defined both in the imported ModuleWithProviders and the parent and getting an extra item in the multi provided array of values. This PR fixes that problem by not pulling providers in ModuleWithProviders up to the parent module. PR Close #34914
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
…cated (angular#34914) The current logic pulls multiproviders up to the parent module's provider list. The result is that the multi provider being defined both in the imported ModuleWithProviders and the parent and getting an extra item in the multi provided array of values. This PR fixes that problem by not pulling providers in ModuleWithProviders up to the parent module. PR Close angular#34914
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic pulls multiproviders up to the parent module's provider list. This results in the multi provider being defined both in the imported ModuleWithProviders and the parent and getting an extra item in the multi provided array of values.