Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): rename getDiagnostics to getSemanticDiagnostics #34909

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Jan 22, 2020

#34888 changed the name of the
API for LanguageService but the patch branch was broken after the commit
landed on master.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

angular#34888 changed the name of the
API for LanguageService but the patch branch was broken after the commit
landed on master.
@kyliau kyliau added area: language-service Issues related to Angular's VS Code language service PR target: patch-only labels Jan 22, 2020
@kyliau kyliau requested a review from a team as a code owner January 22, 2020 20:24
@ngbot ngbot bot modified the milestone: needsTriage Jan 22, 2020
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Keen 👍

@matsko matsko added the action: merge The PR is ready for merge by the caretaker label Jan 22, 2020
matsko pushed a commit that referenced this pull request Jan 22, 2020
#34909)

#34888 changed the name of the
API for LanguageService but the patch branch was broken after the commit
landed on master.

PR Close #34909
@matsko
Copy link
Contributor

matsko commented Jan 22, 2020

landed as 20dc436

@matsko matsko closed this Jan 22, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants