fix(ngcc): implement lockfile #34722

petebacondarwin · 2020-01-10T09:55:41Z

Previously, it was possible for multiple instance of ngcc to be running
at the same time, but this is not supported and can cause confusing and
flakey errors at build time.

Now, only one instance of ngcc can run at a time. If a second instance
tries to execute it fails with an appropriate error message.

See #32431 (comment)

packages/compiler-cli/ngcc/src/execution/lock_file.ts

packages/compiler-cli/ngcc/test/execution/lock_file_spec.ts

JoostK · 2020-01-14T21:59:44Z

packages/compiler-cli/ngcc/src/execution/lock_file.ts

+    process.once('SIGINT', this.signalHandler);
+    process.once('SIGHUP', this.signalHandler);


OOC: Does this work on Windows?

No idea! I am hoping that our CI (or one of our Windows gurus) will test that for me :-)

But to be serious, I looked into it and in theory this should be enough...

packages/compiler-cli/ngcc/test/helpers/mock_lock_file.ts

packages/compiler-cli/ngcc/src/execution/lock_file.ts

gkalpak

Looking good! Some minor comments/questions/suggestions.

packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system.ts

packages/compiler-cli/ngcc/src/main.ts

packages/compiler-cli/ngcc/src/execution/lock_file.ts

petebacondarwin · 2020-01-22T13:26:41Z

@matsko - what is the reason for the presubmit failure?

AndrewKushnir · 2020-01-22T17:31:37Z

@petebacondarwin it looks like there were some pre-existing failing tests. I marked "google3" check as passing for this PR. Thank you.

matsko · 2020-01-22T19:38:51Z

@petebacondarwin please rebase.

This commit adds an `exclusive` parameter to the `FileSystem.writeFile()` method. When this parameter is true, the method will fail with an `EEXIST` error if the file already exists on disk.

Previously, it was possible for multiple instance of ngcc to be running at the same time, but this is not supported and can cause confusing and flakey errors at build time. Now, only one instance of ngcc can run at a time. If a second instance tries to execute it fails with an appropriate error message. See angular#32431 (comment)

The Angular CLI will continue to call ngcc on all possible packages, even if they have already been processed by ngcc in a postinstall script. In a parallel build environment, this was causing ngcc to complain that it was being run in more than one process at the same time. This commit moves the check for whether the targeted package has been processed outside the locked code section, since there is no issue with multiple ngcc processes from doing this check.

Similar to c602563 this commit aligns the node.js version requirements of the Angular compiler with Angular CLI.

petebacondarwin · 2020-01-22T19:54:00Z

@matsko - done.

This commit adds an `exclusive` parameter to the `FileSystem.writeFile()` method. When this parameter is true, the method will fail with an `EEXIST` error if the file already exists on disk. PR Close #34722

Previously, it was possible for multiple instance of ngcc to be running at the same time, but this is not supported and can cause confusing and flakey errors at build time. Now, only one instance of ngcc can run at a time. If a second instance tries to execute it fails with an appropriate error message. See #32431 (comment) PR Close #34722

The Angular CLI will continue to call ngcc on all possible packages, even if they have already been processed by ngcc in a postinstall script. In a parallel build environment, this was causing ngcc to complain that it was being run in more than one process at the same time. This commit moves the check for whether the targeted package has been processed outside the locked code section, since there is no issue with multiple ngcc processes from doing this check. PR Close #34722

Similar to c602563 this commit aligns the node.js version requirements of the Angular compiler with Angular CLI. PR Close #34722

PR Close #34722

This commit adds an `exclusive` parameter to the `FileSystem.writeFile()` method. When this parameter is true, the method will fail with an `EEXIST` error if the file already exists on disk. PR Close #34722

Previously, it was possible for multiple instance of ngcc to be running at the same time, but this is not supported and can cause confusing and flakey errors at build time. Now, only one instance of ngcc can run at a time. If a second instance tries to execute it fails with an appropriate error message. See #32431 (comment) PR Close #34722

The Angular CLI will continue to call ngcc on all possible packages, even if they have already been processed by ngcc in a postinstall script. In a parallel build environment, this was causing ngcc to complain that it was being run in more than one process at the same time. This commit moves the check for whether the targeted package has been processed outside the locked code section, since there is no issue with multiple ngcc processes from doing this check. PR Close #34722

Similar to c602563 this commit aligns the node.js version requirements of the Angular compiler with Angular CLI. PR Close #34722

angular/angular#34722

PR Close angular#34722

This commit adds an `exclusive` parameter to the `FileSystem.writeFile()` method. When this parameter is true, the method will fail with an `EEXIST` error if the file already exists on disk. PR Close angular#34722

Previously, it was possible for multiple instance of ngcc to be running at the same time, but this is not supported and can cause confusing and flakey errors at build time. Now, only one instance of ngcc can run at a time. If a second instance tries to execute it fails with an appropriate error message. See angular#32431 (comment) PR Close angular#34722

…4722) The Angular CLI will continue to call ngcc on all possible packages, even if they have already been processed by ngcc in a postinstall script. In a parallel build environment, this was causing ngcc to complain that it was being run in more than one process at the same time. This commit moves the check for whether the targeted package has been processed outside the locked code section, since there is no issue with multiple ngcc processes from doing this check. PR Close angular#34722

Similar to c602563 this commit aligns the node.js version requirements of the Angular compiler with Angular CLI. PR Close angular#34722

angular-automatic-lock-bot · 2020-02-23T16:08:19Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jan 10, 2020

petebacondarwin force-pushed the ngcc-lockfile branch from 6519660 to ee60c99 Compare January 10, 2020 12:16

petebacondarwin added the state: WIP label Jan 10, 2020

petebacondarwin force-pushed the ngcc-lockfile branch from ee60c99 to 9a37183 Compare January 13, 2020 08:00

petebacondarwin changed the title ~~Ngcc lockfile~~ fix(ngcc): implement lockfile Jan 13, 2020

petebacondarwin added comp: ngcc action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release and removed state: WIP labels Jan 13, 2020

ngbot bot modified the milestone: needsTriage Jan 13, 2020

petebacondarwin marked this pull request as ready for review January 13, 2020 08:01

ngbot bot added this to the needsTriage milestone Jan 13, 2020

petebacondarwin requested review from a team as code owners January 13, 2020 08:01

petebacondarwin force-pushed the ngcc-lockfile branch from 9a37183 to a7f3eed Compare January 13, 2020 09:46

petebacondarwin modified the milestones: needsTriage, v9-candidates Jan 13, 2020

petebacondarwin force-pushed the ngcc-lockfile branch from a7f3eed to 023a995 Compare January 13, 2020 22:04

JoostK reviewed Jan 14, 2020

View reviewed changes

petebacondarwin force-pushed the ngcc-lockfile branch 2 times, most recently from 2f60cef to 2157c9b Compare January 16, 2020 08:21

JoostK reviewed Jan 16, 2020

View reviewed changes

packages/compiler-cli/ngcc/src/execution/lock_file.ts Outdated Show resolved Hide resolved

packages/compiler-cli/ngcc/src/execution/lock_file.ts Outdated Show resolved Hide resolved

petebacondarwin force-pushed the ngcc-lockfile branch from 2157c9b to 9ccf5a4 Compare January 16, 2020 08:35

gkalpak requested changes Jan 16, 2020

View reviewed changes

petebacondarwin force-pushed the ngcc-lockfile branch from 6456953 to 673e4a3 Compare January 17, 2020 09:43

petebacondarwin requested a review from a team as a code owner January 17, 2020 09:43

petebacondarwin requested review from gkalpak and JoostK January 17, 2020 09:43

petebacondarwin force-pushed the ngcc-lockfile branch from 673e4a3 to f16e7e4 Compare January 17, 2020 09:54

petebacondarwin removed the action: presubmit The PR is in need of a google3 presubmit label Jan 22, 2020

petebacondarwin added 5 commits January 22, 2020 19:51

refactor(ivy): add removeFile to ngtsc FileSystem

713bc8f

refactor(ivy): add exclusive mode to writeFile()

32a3f71

This commit adds an `exclusive` parameter to the `FileSystem.writeFile()` method. When this parameter is true, the method will fail with an `EEXIST` error if the file already exists on disk.

feat(compiler-cli): require node 10 as runtime engine

7a644ef

Similar to c602563 this commit aligns the node.js version requirements of the Angular compiler with Angular CLI.

petebacondarwin force-pushed the ngcc-lockfile branch from 84bcaee to 7a644ef Compare January 22, 2020 19:53

AndrewKushnir closed this in ecbc250 Jan 22, 2020

AndrewKushnir pushed a commit that referenced this pull request Jan 22, 2020

feat(compiler-cli): require node 10 as runtime engine (#34722)

d15cf60

Similar to c602563 this commit aligns the node.js version requirements of the Angular compiler with Angular CLI. PR Close #34722

AndrewKushnir pushed a commit that referenced this pull request Jan 22, 2020

refactor(ivy): add removeFile to ngtsc FileSystem (#34722)

aa4f6c6

PR Close #34722

AndrewKushnir pushed a commit that referenced this pull request Jan 22, 2020

feat(compiler-cli): require node 10 as runtime engine (#34722)

7b77b3d

Similar to c602563 this commit aligns the node.js version requirements of the Angular compiler with Angular CLI. PR Close #34722

petebacondarwin deleted the ngcc-lockfile branch January 23, 2020 08:54

jeripeierSBB pushed a commit to sbb-design-systems/sbb-angular that referenced this pull request Jan 30, 2020

fix: use serialized way of executing npm build

e2a46da

angular/angular#34722

sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Feb 13, 2020

refactor(ivy): add removeFile to ngtsc FileSystem (angular#34722)

ab2567f

PR Close angular#34722

angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ngcc): implement lockfile #34722

fix(ngcc): implement lockfile #34722

petebacondarwin commented Jan 10, 2020 •

edited by gkalpak

JoostK Jan 14, 2020

petebacondarwin Jan 15, 2020

petebacondarwin Jan 15, 2020

gkalpak left a comment

petebacondarwin commented Jan 22, 2020

AndrewKushnir commented Jan 22, 2020

matsko commented Jan 22, 2020

petebacondarwin commented Jan 22, 2020

angular-automatic-lock-bot bot commented Feb 23, 2020

		process.once('SIGINT', this.signalHandler);
		process.once('SIGHUP', this.signalHandler);

fix(ngcc): implement lockfile #34722

fix(ngcc): implement lockfile #34722

Conversation

petebacondarwin commented Jan 10, 2020 • edited by gkalpak

JoostK Jan 14, 2020

Choose a reason for hiding this comment

petebacondarwin Jan 15, 2020

Choose a reason for hiding this comment

petebacondarwin Jan 15, 2020

Choose a reason for hiding this comment

gkalpak left a comment

Choose a reason for hiding this comment

petebacondarwin commented Jan 22, 2020

AndrewKushnir commented Jan 22, 2020

matsko commented Jan 22, 2020

petebacondarwin commented Jan 22, 2020

angular-automatic-lock-bot bot commented Feb 23, 2020

petebacondarwin commented Jan 10, 2020 •

edited by gkalpak