fix(animations): not waiting for child animations to finish when removing parent in Ivy #34702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
33597/ivy-animate-child
branch
from
02dde6f
to
0667883
Compare
…ving parent in Ivy In angular#28162 we introduced an extra `removeNode` call for host elements which can cause the parent element to be removed before all child animations have finished. The issue is only in Ivy, because that the only place where we pass in the `isHostElement` flag. These changes fix the issue by not re-triggering the removal logic if the element has in-progress animations. Fixes angular#33597.
crisbeto
force-pushed
the
33597/ivy-animate-child
branch
from
0667883
to
6b05a48
Compare
crisbeto
added
area: animations
comp: ivy
action: review
matsko
approved these changes
Jan 15, 2020
crisbeto
added
action: merge
matsko
pushed a commit
that referenced
this pull request
Jan 21, 2020
…ving parent in Ivy (#34702) In #28162 we introduced an extra `removeNode` call for host elements which can cause the parent element to be removed before all child animations have finished. The issue is only in Ivy, because that the only place where we pass in the `isHostElement` flag. These changes fix the issue by not re-triggering the removal logic if the element has in-progress animations. Fixes #33597. PR Close #34702
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
…ving parent in Ivy (angular#34702) In angular#28162 we introduced an extra `removeNode` call for host elements which can cause the parent element to be removed before all child animations have finished. The issue is only in Ivy, because that the only place where we pass in the `isHostElement` flag. These changes fix the issue by not re-triggering the removal logic if the element has in-progress animations. Fixes angular#33597. PR Close angular#34702
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #28162 we introduced an extra
removeNodecall for host elements which can cause the parent element to be removed before all child animations have finished. The issue is only in Ivy, because that 's the only place where we pass in theisHostElementflag. These changes fix the issue by not re-triggering the removal logic if the element has in-progress animations.Fixes #33597.