ngcc: packages that fail with errors causes a crash #34500

JoostK · 2019-12-19T21:15:06Z

🐞 bug report

Affected Package

The issue is caused by package @angular/compiler-cli

Is this a regression?

Yes, the previous version in which this bug was not present was: 9.0.0-rc.6

Description

When ngcc processes a package that fails to compile, a fatal error that crashes the compiler occurs.

🔬 Minimal Reproduction

For example angular-tree-component fails to compile:
https://app.circleci.com/jobs/github/angular/ngcc-validation/2459/parallel-runs/1?filterBy=ALL

🔥 Exception or Error


ERROR in Cannot read property 'injectorImports' of undefined

🌍 Your Environment

Angular Version:


Angular: 9.0.0-rc.7

Anything else relevant?
n/a

The text was updated successfully, but these errors were encountered:

exequiel09 · 2019-12-20T00:43:52Z

Experienced the same:

NicolasKritter · 2019-12-20T13:38:50Z

Same error, after some investigation the error seems to be from this file :
node_modules\@angular\compiler-cli\src\ngtsc\annotations\src\ng_module.js

at the beginning of the function NgModuleDecoratorHandler.prototype.compile = function (node, analysis, resolution)
at line 347

var ngInjectorDef = compiler_1.compileInjector(tslib_1.__assign(tslib_1.__assign({}, analysis.inj), { imports: tslib_1.__spread(analysis.inj.imports, resolution.injectorImports) }));

The problem is that the variable resolution is undefined
I added this line just before,
if(!resolution){ resolution = {injectorImports:[]}; console.log('no Injector') }
the error is gone but I end up with other error later with a dependendy that is not compatible with ivy (had problem with this before) so I can't tell if this really fix the issue or not but might be worth a try

agustinvinao · 2019-12-21T13:42:29Z

Trying to compile with bazel, same error for another module:

Error: Error on worker #4: TypeError: Cannot read property 'injectorImports' of undefined
    at NgModuleDecoratorHandler.compile (/Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/@angular/compiler-cli/src/ngtsc/annotations/src/ng_module.js:347:174)
    at _loop_1 (/Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/@angular/compiler-cli/ngcc/src/analysis/decoration_analyzer.js:205:38)
    at DecorationAnalyzer.compileClass (/Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/@angular/compiler-cli/ngcc/src/analysis/decoration_analyzer.js:220:21)
    at /Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/@angular/compiler-cli/ngcc/src/analysis/decoration_analyzer.js:194:41
    at Array.map (<anonymous>)
    at DecorationAnalyzer.compileFile (/Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/@angular/compiler-cli/ngcc/src/analysis/decoration_analyzer.js:193:64)
    at /Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/@angular/compiler-cli/ngcc/src/analysis/decoration_analyzer.js:133:90
    at Array.map (<anonymous>)
    at DecorationAnalyzer.analyzeProgram (/Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/@angular/compiler-cli/ngcc/src/analysis/decoration_analyzer.js:133:47)
    at Transformer.analyzeProgram (/Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/@angular/compiler-cli/ngcc/src/packages/transformer.js:123:57)
    at ClusterMaster.onWorkerMessage (/Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/@angular/compiler-cli/ngcc/src/execution/cluster/master.js:158:27)
    at /Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/@angular/compiler-cli/ngcc/src/execution/cluster/master.js:46:95
    at ClusterMaster.<anonymous> (/Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/@angular/compiler-cli/ngcc/src/execution/cluster/master.js:238:57)
    at step (/Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/tslib/tslib.js:136:27)
    at Object.next (/Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/tslib/tslib.js:117:57)
    at /Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/tslib/tslib.js:110:75
    at new Promise (<anonymous>)
    at Object.__awaiter (/Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/tslib/tslib.js:106:16)
    at EventEmitter.<anonymous> (/Users/agustinvinao/development/codespacelabs/bookkeeper/node_modules/@angular/compiler-cli/ngcc/src/execution/cluster/master.js:232:32)
    at EventEmitter.emit (events.js:210:5)

grapehunter · 2019-12-25T09:59:37Z

The same error when running ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points
First execution error, second execution is correct

ottodranik · 2019-12-25T18:46:49Z

Same problem. Tried to upgrade to "next" because ngx-echarts not compiled with ngcc 8.3.9-21 and got this error on upgrade.

sovushka-utrom · 2020-01-03T09:54:52Z

Same for me for Angular: 9.0.0-rc.7:
Compiling @angular/cdk/observers : es2015 as esm2015 Error: Error on worker #3: TypeError: Cannot read property 'injectorImports' of undefined at NgModuleDecoratorHandler.compile ... at EventEmitter.emit (events.js:182:13) Compiling @angular/common/http : es2015 as esm2015.

Happens on npm install that calls the recommended
"postinstall": "ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points".

sovushka-utrom · 2020-01-03T10:02:19Z

I had to remove all the node modules folder & run npm install again. Then it worked.

gustavobmichel · 2020-01-03T10:45:02Z

Have you guys found a way to check which package is causing the issue? I tried to looking at the logs but it doesn't seem to include the package with the problem.

benelliott · 2020-01-03T12:41:44Z

@gustavobmichel My logs show the symbol that caused the issue. Can you upload yours?

gnanakeethan · 2020-01-05T14:11:52Z

I am using Yarn, and I tried doing a Yarn Upgrade. Then ran the Yarn Install. It worked without an issue.

In angular#34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an error state, which prevents it from being ran through subsequent phases. The ngcc compiler on the other hand did not adopt this strict error model, which would cause incomplete metadata—due to errors in earlier phases—to be offered for compilation that could result in a hard crash. This commit changes ngcc so that it starts using ngtsc's `Trait` concept to track transitions between the analysis, resolve and compile phase much more explicitly. This approach makes it illegal to attempt the compile phase when either analysis or resolve has produced errors, avoiding the crash. Fixes angular#34500 Resolves FW-1788

vokeit-gschuster · 2020-01-15T10:24:26Z

Just FYI, when using the nightly build the bug is fixed.
Simply download @angular/compiler-cli-builds (https://github.com/angular/compiler-cli-builds) and replace it in node_modules.

JoostK · 2020-01-15T10:35:39Z

@vokeit-gschuster The bug itself has not been fixed, the fix PR is still pending. However, it may be that a bug which was causing the library to fail compiling has been fixed, in which case you won't observe the bug anymore.

vokeit-gschuster · 2020-01-15T11:13:19Z

In my case, ngcc failed with the above given message on @angular/http/testing when only running it on node_modules ("ngcc" in the workspace root).

wuboy0307 · 2020-01-16T07:42:54Z

In my case, ngcc failed with the above given message on angular-tree-component when compile to esm5

Compiling angular-tree-component : module as esm5
Error: Error on worker #3: TypeError: Cannot read property 'injectorImports' of undefined

In angular#34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an error state, which prevents it from being ran through subsequent phases. The ngcc compiler on the other hand did not adopt this strict error model, which would cause incomplete metadata—due to errors in earlier phases—to be offered for compilation that could result in a hard crash. This commit changes ngcc so that it starts using ngtsc's `Trait` concept to track transitions between the analysis, resolve and compile phase much more explicitly. This approach makes it illegal to attempt the compile phase when either analysis or resolve has produced errors, avoiding the crash. Fixes angular#34500 Resolves FW-1788

In angular#34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an error state, which prevents it from being ran through subsequent phases. The ngcc compiler on the other hand did not adopt this strict error model, which would cause incomplete metadata—due to errors in earlier phases—to be offered for compilation that could result in a hard crash. This commit updates ngcc to take advantage of ngtsc's `TraitCompiler`, that internally manages all Ivy classes that are part of the compilation. This effectively replaces ngcc's own `AnalyzedFile` and `AnalyzedClass` types, together with all of the logic to drive the `DecoratorHandler`s. All of this is now handled in the `TraitCompiler`, benefiting from its explicit state transitions of `Trait`s so that the ngcc crash is a thing of the past. Fixes angular#34500 Resolves FW-1788

kaito3desuyo · 2020-01-22T08:29:54Z

Exact same error on 9.0.0-rc.10.

0% compiling
Compiling <my-angular-component-library> : es2015 as esm2015

ERROR in Cannot read property 'injectorImports' of undefined

In angular#34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an error state, which prevents it from being ran through subsequent phases. The ngcc compiler on the other hand did not adopt this strict error model, which would cause incomplete metadata—due to errors in earlier phases—to be offered for compilation that could result in a hard crash. This commit updates ngcc to take advantage of ngtsc's `TraitCompiler`, that internally manages all Ivy classes that are part of the compilation. This effectively replaces ngcc's own `AnalyzedFile` and `AnalyzedClass` types, together with all of the logic to drive the `DecoratorHandler`s. All of this is now handled in the `TraitCompiler`, benefiting from its explicit state transitions of `Trait`s so that the ngcc crash is a thing of the past. Fixes angular#34500 Resolves FW-1788

In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an error state, which prevents it from being ran through subsequent phases. The ngcc compiler on the other hand did not adopt this strict error model, which would cause incomplete metadata—due to errors in earlier phases—to be offered for compilation that could result in a hard crash. This commit updates ngcc to take advantage of ngtsc's `TraitCompiler`, that internally manages all Ivy classes that are part of the compilation. This effectively replaces ngcc's own `AnalyzedFile` and `AnalyzedClass` types, together with all of the logic to drive the `DecoratorHandler`s. All of this is now handled in the `TraitCompiler`, benefiting from its explicit state transitions of `Trait`s so that the ngcc crash is a thing of the past. Fixes #34500 Resolves FW-1788 PR Close #34889

) In angular#34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an error state, which prevents it from being ran through subsequent phases. The ngcc compiler on the other hand did not adopt this strict error model, which would cause incomplete metadata—due to errors in earlier phases—to be offered for compilation that could result in a hard crash. This commit updates ngcc to take advantage of ngtsc's `TraitCompiler`, that internally manages all Ivy classes that are part of the compilation. This effectively replaces ngcc's own `AnalyzedFile` and `AnalyzedClass` types, together with all of the logic to drive the `DecoratorHandler`s. All of this is now handled in the `TraitCompiler`, benefiting from its explicit state transitions of `Trait`s so that the ngcc crash is a thing of the past. Fixes angular#34500 Resolves FW-1788 PR Close angular#34889

angular-automatic-lock-bot · 2020-02-23T16:09:27Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

JoostK added comp: ngcc type: bug/fix labels Dec 19, 2019

ngbot bot added this to the needsTriage milestone Dec 19, 2019

JoostK added the freq1: low label Dec 19, 2019

ngbot bot modified the milestones: needsTriage, Backlog Dec 19, 2019

This comment has been minimized.

Sign in to view

JoostK self-assigned this Jan 5, 2020

manughub modified the milestones: Backlog, v9-blockers Jan 6, 2020

JoostK mentioned this issue Jan 6, 2020

fix(ngcc): do not attempt compilation when analysis fails #34652

Closed

JoostK added the state: has PR label Jan 6, 2020

alxhub mentioned this issue Jan 14, 2020

ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths #34755

Closed

wuboy0307 mentioned this issue Jan 21, 2020

fail to install for angular 9 and ivy CirclonGroup/angular-tree-component#783

Closed

JoostK mentioned this issue Jan 21, 2020

fix(ngcc): switch ngcc over to use the TraitCompiler #34889

Closed

AndrewKushnir closed this as completed in 7659f2e Jan 23, 2020

angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ngcc: packages that fail with errors causes a crash #34500

ngcc: packages that fail with errors causes a crash #34500

JoostK commented Dec 19, 2019

exequiel09 commented Dec 20, 2019

NicolasKritter commented Dec 20, 2019 •

edited

agustinvinao commented Dec 21, 2019

grapehunter commented Dec 25, 2019 •

edited

ottodranik commented Dec 25, 2019 •

edited

This comment has been minimized.

sovushka-utrom commented Jan 3, 2020

sovushka-utrom commented Jan 3, 2020

gustavobmichel commented Jan 3, 2020

benelliott commented Jan 3, 2020

gnanakeethan commented Jan 5, 2020

vokeit-gschuster commented Jan 15, 2020

JoostK commented Jan 15, 2020

vokeit-gschuster commented Jan 15, 2020

wuboy0307 commented Jan 16, 2020

kaito3desuyo commented Jan 22, 2020

angular-automatic-lock-bot bot commented Feb 23, 2020

ngcc: packages that fail with errors causes a crash #34500

ngcc: packages that fail with errors causes a crash #34500

Comments

JoostK commented Dec 19, 2019

🐞 bug report

Affected Package

Is this a regression?

Description

🔬 Minimal Reproduction

🔥 Exception or Error

🌍 Your Environment

exequiel09 commented Dec 20, 2019

NicolasKritter commented Dec 20, 2019 • edited

agustinvinao commented Dec 21, 2019

grapehunter commented Dec 25, 2019 • edited

ottodranik commented Dec 25, 2019 • edited

This comment has been minimized.

sovushka-utrom commented Jan 3, 2020

sovushka-utrom commented Jan 3, 2020

gustavobmichel commented Jan 3, 2020

benelliott commented Jan 3, 2020

gnanakeethan commented Jan 5, 2020

vokeit-gschuster commented Jan 15, 2020

JoostK commented Jan 15, 2020

vokeit-gschuster commented Jan 15, 2020

wuboy0307 commented Jan 16, 2020

kaito3desuyo commented Jan 22, 2020

angular-automatic-lock-bot bot commented Feb 23, 2020

NicolasKritter commented Dec 20, 2019 •

edited

grapehunter commented Dec 25, 2019 •

edited

ottodranik commented Dec 25, 2019 •

edited