Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): i18n - handle translated text containing HTML comments #32475

Closed
wants to merge 1 commit into from
Closed

fix(ivy): i18n - handle translated text containing HTML comments #32475

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin commented Sep 4, 2019 •
edited

Fixes FW-1536

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@petebacondarwin petebacondarwin added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n target: major This PR is targeted for the next major release comp: ivy area: compiler Issues related to `ngc`, Angular's template compiler labels Sep 4, 2019
@petebacondarwin petebacondarwin requested review from a team as code owners September 4, 2019 15:29
@ngbot ngbot bot modified the milestone: needsTriage Sep 4, 2019
AndrewKushnir
AndrewKushnir approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @petebacondarwin!

@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Sep 4, 2019
@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit labels Sep 4, 2019
@mhevery mhevery closed this in 5d8eb74 Sep 4, 2019
@petebacondarwin petebacondarwin deleted the i18n-FW-1536 branch September 4, 2019 20:06
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@petebacondarwin @sabeersulaiman
fix(ivy): i18n - handle translated text containing HTML comments (ang…
6006419 
…ular#32475)

Fixes FW-1536

PR Close angular#32475
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@petebacondarwin @arnehoek
fix(ivy): i18n - handle translated text containing HTML comments (ang…
10dd338 
…ular#32475)

Fixes FW-1536

PR Close angular#32475
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: i18n cla: yes target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petebacondarwin @AndrewKushnir @googlebot