Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(ivy): properly initialise global state in the element_text_create benchmark #32397

Closed
wants to merge 1 commit into from
Closed

perf(ivy): properly initialise global state in the element_text_create benchmark #32397

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

Without the resetComponentState() the elementDepthCount global state was undefined so trying to increment / decrement it was causing type coercion which was showing up under a profiler

@pkozlowski-opensource pkozlowski-opensource added comp: ivy action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Aug 29, 2019
@ngbot ngbot bot modified the milestone: needsTriage Aug 29, 2019
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review August 30, 2019 09:39
@pkozlowski-opensource pkozlowski-opensource requested a review from a team as a code owner August 30, 2019 09:39
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 30, 2019
@mhevery mhevery closed this in 8dc3f36 Aug 30, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@pkozlowski-opensource @sabeersulaiman
perf(ivy): properly initialise global state in the element_text_creat…
96172e1 
…e benchmark (angular#32397)

PR Close angular#32397
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@pkozlowski-opensource @arnehoek
perf(ivy): properly initialise global state in the element_text_creat…
437bee0 
…e benchmark (angular#32397)

PR Close angular#32397
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pkozlowski-opensource @mhevery @googlebot