fix(common): http/testing expectOne lists the received requests #27005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
force-pushed
the
fix/18013-expect-one
branch
from
3571fe7
to
9d8d0b7
Compare
cexbrayat
force-pushed
the
fix/18013-expect-one
branch
from
9d8d0b7
to
347c333
Compare
cexbrayat
force-pushed
the
fix/18013-expect-one
branch
2 times, most recently
from
f87c9f4
to
0996ee3
Compare
cexbrayat
force-pushed
the
fix/18013-expect-one
branch
from
0996ee3
to
6a992b8
Compare
petebacondarwin
approved these changes
Jan 21, 2020
petebacondarwin
added
area: testing
alxhub
approved these changes
Jan 21, 2020
petebacondarwin
added
action: presubmit
|
Caretaker: the presubmit errors are legit. 290817196 contains the necessary g3 patches. |
cexbrayat
force-pushed
the
fix/18013-expect-one
branch
from
e98044a
to
b99ca9e
Compare
cexbrayat
added
action: merge
… matches Fixes angular#18013 Previously it was hard to debug an `expectOne` if the request had no match, as the error message was: Expected one matching request for criteria "Match URL: /some-url?query=hello", found none. This commit adds a bit more info to the error, by listing the actual requests received: Expected one matching request for criteria "Match URL: /some-url?query=hello", found none. Requests received are: POST /some-url?query=world.
AndrewKushnir
force-pushed
the
fix/18013-expect-one
branch
from
b99ca9e
to
3c1840a
Compare
|
FYI, I submitted a change in g3 to adapt some code to upcoming changes from this PR. Once it's merged, I will run another presubmit and remove the "blocked" label if everything goes well. Thank you. |
AndrewKushnir
added
risk: medium
and removed
action: presubmit
|
FYI, g3 presubmit is now passing (after respective changes in g3), this PR is ready to be merged. |
mhevery
pushed a commit
that referenced
this pull request
Jan 31, 2020
… matches (#27005) Fixes #18013 Previously it was hard to debug an `expectOne` if the request had no match, as the error message was: Expected one matching request for criteria "Match URL: /some-url?query=hello", found none. This commit adds a bit more info to the error, by listing the actual requests received: Expected one matching request for criteria "Match URL: /some-url?query=hello", found none. Requests received are: POST /some-url?query=world. PR Close #27005
mhevery
pushed a commit
that referenced
this pull request
Jan 31, 2020
mhevery
pushed a commit
that referenced
this pull request
Jan 31, 2020
mhevery
pushed a commit
that referenced
this pull request
Jan 31, 2020
… matches (#27005) Fixes #18013 Previously it was hard to debug an `expectOne` if the request had no match, as the error message was: Expected one matching request for criteria "Match URL: /some-url?query=hello", found none. This commit adds a bit more info to the error, by listing the actual requests received: Expected one matching request for criteria "Match URL: /some-url?query=hello", found none. Requests received are: POST /some-url?query=world. PR Close #27005
mhevery
pushed a commit
that referenced
this pull request
Jan 31, 2020
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
… matches (angular#27005) Fixes angular#18013 Previously it was hard to debug an `expectOne` if the request had no match, as the error message was: Expected one matching request for criteria "Match URL: /some-url?query=hello", found none. This commit adds a bit more info to the error, by listing the actual requests received: Expected one matching request for criteria "Match URL: /some-url?query=hello", found none. Requests received are: POST /some-url?query=world. PR Close angular#27005
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Previously it was hard to debug an
expectOneif the request had no match, as the error message was:Issue Number: #18013
What is the new behavior?
This commit adds a bit more info to the error, by listing the actual requests received, if there are some (doesn't change the message if no requests were received):
Does this PR introduce a breaking change?