Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 7.0.x build #26875

Closed
wants to merge 2 commits into from
Closed

Fix 7.0.x build #26875

wants to merge 2 commits into from

Conversation

gregmagolan
Copy link
Contributor

No description provided.

@gregmagolan gregmagolan changed the base branch from master to 7.0.x October 31, 2018 16:05
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link

CLAs look good, thanks!

@gregmagolan
Copy link
Contributor Author

@IgorMinar Looks like the 7.0.x build was broken when #26788 was merged in

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Oct 31, 2018
matsko pushed a commit that referenced this pull request Oct 31, 2018
matsko pushed a commit that referenced this pull request Oct 31, 2018
@matsko
Copy link
Contributor

matsko commented Oct 31, 2018

Landed as bc93d47

@matsko matsko closed this Oct 31, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants