Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixup deployment guide #26486

Closed
wants to merge 1 commit into from
Closed

docs: fixup deployment guide #26486

wants to merge 1 commit into from

Conversation

IgorMinar
Copy link
Contributor

  • remove sections that were not relevant (all the development stuff)
  • fix incorrect info

@IgorMinar IgorMinar added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Oct 16, 2018
gkalpak
gkalpak reviewed Oct 16, 2018
View reviewed changes
aio/content/guide/deployment.md Outdated

Angular apps run in development mode by default, as you can see by the following message on the browser
console:
In addion to build optimizations, Angular also has a runtime production mode. Angular apps run in development mode by default, as you can see by the following message on the browser console:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addion --> addition

@ngbot ngbot bot added this to the needsTriage milestone Oct 18, 2018
@IgorMinar IgorMinar force-pushed the IgorMinar-patch-5 branch 2 times, most recently from 524fcf9 to c63a911 Compare October 22, 2018 21:04
jenniferfell
jenniferfell approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@jenniferfell jenniferfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No show stoppers. Still in the backlog for a more substantial rewrite.

@jenniferfell jenniferfell mentioned this pull request Oct 22, 2018
Closed
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 23, 2018
@ngbot
Copy link

ngbot bot commented Oct 23, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: publish_snapshot" is failing
    pending status "continuous-integration/travis-ci/push" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 23, 2018
@IgorMinar
Copy link
Contributor Author

caretaker note: unrelated ci failure

@IgorMinar
docs: fixup deployment guide
064f0d0 
- remove sections that were not relevant (all the development stuff)
- fix incorrect info
@matsko matsko closed this in 62b4ff5 Oct 30, 2018
matsko pushed a commit that referenced this pull request Oct 30, 2018
@IgorMinar @matsko
docs: fixup deployment guide (#26486)
40cd037 
- remove sections that were not relevant (all the development stuff)
- fix incorrect info

PR Close #26486
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
@IgorMinar @sculove
docs: fixup deployment guide (angular#26486)
dd0117e 
- remove sections that were not relevant (all the development stuff)
- fix incorrect info

PR Close angular#26486
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@IgorMinar @FrederikSchlemmer
docs: fixup deployment guide (angular#26486)
4e05a6c 
- remove sections that were not relevant (all the development stuff)
- fix incorrect info

PR Close angular#26486
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
@IgorMinar IgorMinar deleted the IgorMinar-patch-5 branch June 9, 2020 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak left review comments

@jenniferfell jenniferfell jenniferfell approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@IgorMinar @gkalpak @jenniferfell @brandonroberts @googlebot