common/http: expectOne message could be improved

[cexbrayat]

I'm submitting a ...

[ ] Regression (behavior that used to work and stopped working in a new release)
[ ] Bug report 
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

A failed test for an HTTP request gives the following message since #17996:

Expected one matching request for criteria "Match URL: http://localhost:9000/api/users?status=PENDING", found none.

which is better, but still quite hard to debug as we have no idea what the actual request was.

Expected behavior

An ideal message would be something like:

Expected one matching request for criteria "Match URL: http://localhost:9000/api/users?status=PENDING", but only received  "http://localhost:9000/api/users?status=ACTIVE".

Please tell us about your environment

Angular version: 4.3.0-rc.0

[priteshacharya]

Is there any workaround to see the actual request received?

[trotyl]

@priteshacharya Just call verify method after it. (Likely better in afterEach)

[aciccarello]

Verify does not show the request query parameters making mis-matching params very hard to debug.

angular/packages/common/http/testing/src/backend.ts

Lines 126 to 132 in c2dbc55

	const requests = open.map(testReq => {
	const url = testReq.request.urlWithParams.split('?')[0];
	const method = testReq.request.method;
	return `${method} ${url}`;
	})
	.join(', ');
	throw new Error(`Expected no open requests, found ${open.length}: ${requests}`);

A simpler debugging message could just find requests where the urls match and show the different params.

Expected one matching request for criteria "Match URL: http://localhost:9000/api/users Param(s): status=PENDING", but received param(s) "status=ACTIVE"

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}