From dd18cfd983dcb6c3793a3b652ec7e54e5b0201a6 Mon Sep 17 00:00:00 2001 From: Andrew Scott Date: Tue, 1 Dec 2020 12:45:02 -0800 Subject: [PATCH] refactor(language-service): create findRenameLocations stubs (#39919) Create stubs for `findRenameLocations` for both VE and Ivy Language Service implementations. This will prevent failed requests when it is implemented on the vscode plugin side. PR Close #39919 --- packages/language-service/ivy/ts_plugin.ts | 8 ++++++++ packages/language-service/src/ts_plugin.ts | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/packages/language-service/ivy/ts_plugin.ts b/packages/language-service/ivy/ts_plugin.ts index 8c28a2db3538b..a7d5fee16f766 100644 --- a/packages/language-service/ivy/ts_plugin.ts +++ b/packages/language-service/ivy/ts_plugin.ts @@ -61,6 +61,13 @@ export function create(info: ts.server.PluginCreateInfo): ts.LanguageService { return ngLS.getReferencesAtPosition(fileName, position); } + function findRenameLocations( + fileName: string, position: number, findInStrings: boolean, findInComments: boolean, + providePrefixAndSuffixTextForRename?: boolean): readonly ts.RenameLocation[]|undefined { + // TODO(atscott): implement + return undefined; + } + return { ...tsLS, getSemanticDiagnostics, @@ -68,5 +75,6 @@ export function create(info: ts.server.PluginCreateInfo): ts.LanguageService { getQuickInfoAtPosition, getDefinitionAndBoundSpan, getReferencesAtPosition, + findRenameLocations, }; } diff --git a/packages/language-service/src/ts_plugin.ts b/packages/language-service/src/ts_plugin.ts index fbf21b0b21a22..4320a7d5530b7 100644 --- a/packages/language-service/src/ts_plugin.ts +++ b/packages/language-service/src/ts_plugin.ts @@ -128,6 +128,13 @@ export function create(info: tss.server.PluginCreateInfo): tss.LanguageService { return undefined; } + function findRenameLocations( + fileName: string, position: number, findInStrings: boolean, findInComments: boolean, + providePrefixAndSuffixTextForRename?: boolean): readonly ts.RenameLocation[]|undefined { + // not implemented in VE Language Service + return undefined; + } + return { // First clone the original TS language service ...tsLS, @@ -139,5 +146,6 @@ export function create(info: tss.server.PluginCreateInfo): tss.LanguageService { getDefinitionAndBoundSpan, getTypeDefinitionAtPosition, getReferencesAtPosition, + findRenameLocations, }; }