test: use random e2e test ports #23541
Conversation
packages/schematics/angular/e2e/files/protractor.conf.js.template
Outdated
Show resolved
Hide resolved
jbedard
force-pushed
the
random-ports
branch
2 times, most recently
from
8a53863
to
c74e33e
Compare
There was a problem hiding this comment.
Changes other than that in https://github.com/angular/angular-cli/blob/c74e33eef1bbb4fc73e204520f57bba3574891dc/packages/angular_devkit/build_angular/src/builders/dev-server/specs/works_spec.ts should be reverted. For E2E the port should be set in
jbedard
changed the title
|
I don't think that catches all cases but looks like it fixes the ones actually using e2e so is probably enough 👍 |
| appTargets.e2e.options.webdriverUpdate = false; | ||
| // Use a random port in e2e. | ||
| appTargets.e2e.options.port = 0; |
There was a problem hiding this comment.
@alan-agius4 do you think this would also be the ideal place to set appTargets.serve.options.port? I just had a test running ng serve fail in another PR due to 4200 being in use...
There was a problem hiding this comment.
Note there's various ng serve --port=0 throughout the tests already but a few are missing such as
rebuild-deps-type-check.ts
rebuild-types.ts
There was a problem hiding this comment.
I've added another commit but feel free to only merge the first if you'd like.
alan-agius4
added
target: patch
alan-agius4
added
action: merge
* test: use random e2e test ports * test: use random ng serve ports (cherry picked from commit 35c4357)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.