Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerabilty with ejs which is dependant on @angular-eslint/builder ( ejs lacks certain pollution protection ) #1804

Open
pramodhcm opened this issue May 4, 2024 · 1 comment
Labels
package: builder Angular CLI builder which enables executing ESLint in Angular CLI workspaces triage This issue needs to be looked at and categorized by a maintainer

Comments

@pramodhcm
Copy link

Description and versions:
"@angular-eslint/builder": "^16.2.0",
"@nx/devkit": "16.5.1",
"ejs": "^3.1.7",

Run "npm run audit" on new project to reproduce below error
╔══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════╗
║ ║
║ ID │ Module │ Title │ Paths │ Sev. │ URL │ Ex. ║
║ 1097210 │ ejs │ ejs lacks certain pollution protection │ ejs │ moderate │ GHSA-ghr5-ch3p-vcr6 │ n ║
╚═════════╧════════╧════════════════════════════════════════╧═════════════════╧══════════╧═══════════════════════════════════════════════════╧═════╝

PS C:\Users\pramocm\Desktop\XMP- Frontend> ng version

 _                      _                 ____ _     ___
/ \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|

/ △ \ | '_ \ / | | | | |/ _ | '__| | | | | | |
/ ___ | | | | (
| | || | | (| | | | || | | |
// __| ||_, |_,||_,|| _|||
|___/

Angular CLI: 16.2.14
Node: 20.11.0 (Unsupported)
Package Manager: npm 10.3.0
OS: win32 x64

Angular: 16.2.12
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package Version

@angular-devkit/architect 0.1602.14
@angular-devkit/build-angular 16.2.14
@angular-devkit/core 16.2.14
@angular-devkit/schematics 16.2.14
@angular/cli 16.2.14
@schematics/angular 16.2.14
rxjs 7.8.1
typescript 4.9.5
zone.js 0.13.3

Warning: The current version of Node (20.11.0) is not supported by Angular.

@pramodhcm pramodhcm added package: builder Angular CLI builder which enables executing ESLint in Angular CLI workspaces triage This issue needs to be looked at and categorized by a maintainer labels May 4, 2024
@json-derulo
Copy link
Contributor

This looks like a duplicate of #1776. The dependency to ejs comes from @nx/devkit and not from Angular ESLint directly. Also because the dependency range is defined as ^3.1.7, and v3.1.10 is not vulnerable, npm update or npm audit fix should resolve the vulnerability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: builder Angular CLI builder which enables executing ESLint in Angular CLI workspaces triage This issue needs to be looked at and categorized by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants