Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected 9MB binary produced from @angular-eslint/schematics: .nx/cache/18.3.3-nx.linux-x64-gnu.node #1784

Open
johnnygerard opened this issue Apr 22, 2024 · 3 comments

Comments

@johnnygerard
Copy link

johnnygerard commented Apr 22, 2024

A ~9MB binary is generated from @angular-eslint/schematics@17.3.0.
I'm assuming it is a regression bug maybe after your migration to Nx 18.

To reproduce:

ng new app --defaults
cd app
ng add @angular-eslint/schematics --skip-confirmation

You should see this file: app/.nx/cache/18.3.3-nx.linux-x64-gnu.node.

Environment:

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 17.3.5
Node: 20.12.2
Package Manager: npm 10.5.2
OS: linux x64

Angular: 17.3.5
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1703.5
@angular-devkit/build-angular   17.3.5
@angular-devkit/core            17.3.5
@angular-devkit/schematics      17.3.5
@schematics/angular             17.3.5
rxjs                            7.8.1
typescript                      5.4.5
zone.js                         0.14.4

Added dependencies:

    "@angular-eslint/builder": "17.3.0",
    "@angular-eslint/eslint-plugin": "17.3.0",
    "@angular-eslint/eslint-plugin-template": "17.3.0",
    "@angular-eslint/schematics": "17.3.0",
    "@angular-eslint/template-parser": "17.3.0",

    "@typescript-eslint/eslint-plugin": "7.2.0",
    "@typescript-eslint/parser": "7.2.0",
    "eslint": "^8.57.0",
@robertIsaac
Copy link

I think eslint should add .nx to .gitignore

@MonsieurBon
Copy link

MonsieurBon commented May 7, 2024

I also have this file after running ng update @angular/core@17 @angular/cli@17 @angular-eslint/schematics@17. We are not using nx in our project and I'm therefore surprised this is needed!

Shouldn't nx be a dev or peerDependency of angular-eslint?

@tyzess
Copy link

tyzess commented May 7, 2024

Same here. With @angular-eslint 17.3.0 the nx/devkit/nwl dependencies find their way into the project. Even breaks my build process Error: Cannot find module '@nx/nx-linux-x64-gnu'. Why are they suddenly required by @angular-eslint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants